From c5a6efbccfbe23de0e5dcf3c6b76c42cce4a758e Mon Sep 17 00:00:00 2001 From: Victor Fan Date: Fri, 9 Jun 2023 14:33:45 -0700 Subject: [PATCH 1/2] revert rtdb DataSnapshot.exists() behavior to match lodash.isNull --- src/common/providers/database.ts | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/common/providers/database.ts b/src/common/providers/database.ts index 43f977b53..1c587c2ce 100644 --- a/src/common/providers/database.ts +++ b/src/common/providers/database.ts @@ -152,20 +152,12 @@ export class DataSnapshot implements database.DataSnapshot { } /** - * Returns `true` if this `DataSnapshot` contains any data. It is slightly more - * efficient than using `snapshot.val() !== null`. - * + * Returns `true` if this `DataSnapshot` contains any data. + * * @return `true` if this `DataSnapshot` contains any data; otherwise, `false`. */ exists(): boolean { - const val = this.val(); - if (!val || val === null) { - return false; - } - if (typeof val === "object" && Object.keys(val).length === 0) { - return false; - } - return true; + return this.val() !== null; } /** From fb125e6d5edd015c0d68cfdbf394fb9a5497fea2 Mon Sep 17 00:00:00 2001 From: Victor Fan Date: Fri, 9 Jun 2023 14:46:03 -0700 Subject: [PATCH 2/2] fix lint --- src/common/providers/database.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/providers/database.ts b/src/common/providers/database.ts index 1c587c2ce..00d94d669 100644 --- a/src/common/providers/database.ts +++ b/src/common/providers/database.ts @@ -153,7 +153,7 @@ export class DataSnapshot implements database.DataSnapshot { /** * Returns `true` if this `DataSnapshot` contains any data. - * + * * @return `true` if this `DataSnapshot` contains any data; otherwise, `false`. */ exists(): boolean {