Skip to content

Commit c0e0361

Browse files
authored
Change payload based on API council feedback: (#1209)
- combine `display_version` and `build_version` into `app_version`. - change repeated field `screenshot_uris` to (optional) field `screenshot_uri`.
1 parent f9ecee4 commit c0e0361

File tree

1 file changed

+6
-16
lines changed

1 file changed

+6
-16
lines changed

src/v2/providers/alerts/appDistribution.ts

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -60,21 +60,14 @@ export interface InAppFeedbackPayload {
6060
/** Email of the tester */
6161
testerEmail: string;
6262
/**
63-
* Display version of the release. For an Android release, the display version
64-
* is the `versionName`. For an iOS release, the display version is the
65-
* `CFBundleShortVersionString`.
63+
* Version consisting of `versionName` and `versionCode` for Android and
64+
* `CFBundleShortVersionString` and `CFBundleVersion` for iOS.
6665
*/
67-
displayVersion: string;
68-
/**
69-
* Build version of the release. For an Android release, the build version
70-
* is the `versionCode`. For an iOS release, the build version is the
71-
* `CFBundleVersion`.
72-
*/
73-
buildVersion: string;
66+
appVersion: string;
7467
/** Text entered by the tester */
7568
text: string;
76-
/** URIs to download screenshot(s). These URIs are fast expiring. */
77-
screenshotUris: string[];
69+
/** URI to download screenshot. This URIs are is fast expiring. */
70+
screenshotUri?: string;
7871
}
7972

8073
/**
@@ -332,10 +325,7 @@ export function onInAppFeedbackPublished(
332325
const [opts, appId] = getOptsAndApp(appIdOrOptsOrHandler);
333326

334327
const func = (raw: CloudEvent<unknown>) => {
335-
const event = raw as AppDistributionEvent<InAppFeedbackPayload>;
336-
// Consolidate the case of empty array and null array
337-
event.data.payload.screenshotUris = event.data.payload.screenshotUris || [];
338-
return handler(event);
328+
return handler(raw as AppDistributionEvent<InAppFeedbackPayload>);
339329
};
340330

341331
func.run = handler;

0 commit comments

Comments
 (0)