Merge branch 'main' into feature/m98-release-update-dependencies

Author: vimanyu

cmake/external/firestore.cmake

@@ -18,7 +18,7 @@ if(TARGET firestore)
   return()
 endif()
 
-set(version CocoaPods-7.11.0)
+set(version CocoaPods-8.2.0)
 ExternalProject_Add(
   firestore
 

firestore/integration_test_internal/Podfile

@@ -1,4 +1,5 @@
 source 'https://github.com/CocoaPods/Specs.git'
+platform :ios, '10.0'
 # Cloud Firestore internal test application.
 
 target 'integration_test' do

firestore/integration_test_internal/integration_test.xcodeproj/project.pbxproj

@@ -94,6 +94,25 @@ class BundleTest : public FirestoreIntegrationTest {
                                MapFieldValue{{"k", FieldValue::String("b")},
                                              {"bar", FieldValue::Integer(2)}}));
     }
+
+    {
+      Query limit = AwaitResult(db->NamedQuery(kLimitQueryName));
+      auto limit_snapshot = AwaitResult(limit.Get(Source::kCache));
+      EXPECT_THAT(
+          QuerySnapshotToValues(limit_snapshot),
+          testing::ElementsAre(MapFieldValue{{"k", FieldValue::String("b")},
+                                             {"bar", FieldValue::Integer(2)}}));
+    }
+
+    {
+      Query limit_to_last = AwaitResult(db->NamedQuery(kLimitToLastQueryName));
+      auto limit_to_last_snapshot =
+          AwaitResult(limit_to_last.Get(Source::kCache));
+      EXPECT_THAT(
+          QuerySnapshotToValues(limit_to_last_snapshot),
+          testing::ElementsAre(MapFieldValue{{"k", FieldValue::String("a")},
+                                             {"bar", FieldValue::Integer(1)}}));
+    }
   }
 };
 
@@ -240,6 +259,21 @@ TEST_F(BundleTest, LoadBundleWithDocumentsAlreadyPulledFromBackend) {
               testing::ElementsAre(
                   MapFieldValue{{"bar", FieldValue::String("newValueA")}},
                   MapFieldValue{{"bar", FieldValue::String("newValueB")}}));
+
+  {
+    Query limit = AwaitResult(db->NamedQuery(kLimitQueryName));
+    EXPECT_THAT(QuerySnapshotToValues(AwaitResult(limit.Get(Source::kCache))),
+                testing::ElementsAre(
+                    MapFieldValue{{"bar", FieldValue::String("newValueB")}}));
+  }
+
+  {
+    Query limit_to_last = AwaitResult(db->NamedQuery(kLimitToLastQueryName));
+    EXPECT_THAT(
+        QuerySnapshotToValues(AwaitResult(limit_to_last.Get(Source::kCache))),
+        testing::ElementsAre(
+            MapFieldValue{{"bar", FieldValue::String("newValueA")}}));
+  }
 }
 
 TEST_F(BundleTest, LoadedDocumentsShouldNotBeGarbageCollectedRightAway) {
@@ -282,6 +316,28 @@ TEST_F(BundleTest, LoadDocumentsFromOtherProjectsShouldFail) {
   VerifyErrorProgress(progresses[1]);
 }
 
+TEST_F(BundleTest, GetInvalidNamedQuery) {
+  Firestore* db = TestFirestore();
+  {
+    auto future = db->NamedQuery("DOES_NOT_EXIST");
+    Await(future);
+    EXPECT_EQ(future.status(), FutureStatus::kFutureStatusComplete);
+    EXPECT_EQ(future.error(), Error::kErrorNotFound);
+  }
+  {
+    auto future = db->NamedQuery("");
+    Await(future);
+    EXPECT_EQ(future.status(), FutureStatus::kFutureStatusComplete);
+    EXPECT_EQ(future.error(), Error::kErrorNotFound);
+  }
+  {
+    auto future = db->NamedQuery("\xc3\x28");
+    Await(future);
+    EXPECT_EQ(future.status(), FutureStatus::kFutureStatusComplete);
+    EXPECT_EQ(future.error(), Error::kErrorNotFound);
+  }
+}
+
 }  // namespace
 }  // namespace firestore
 }  // namespace firebase

firestore/integration_test_internal/src/bundle_test.cc

@@ -338,5 +338,10 @@ Future<LoadBundleTaskProgress> Firestore::LoadBundle(
   return internal_->LoadBundle(bundle, std::move(progress_callback));
 }
 
+Future<Query> Firestore::NamedQuery(const std::string& query_name) {
+  if (!internal_) return FailedFuture<Query>();
+  return internal_->NamedQuery(query_name);
+}
+
 }  // namespace firestore
 }  // namespace firebase

firestore/src/common/firestore.cc

@@ -429,6 +429,21 @@ class Firestore {
       const std::string& bundle,
       std::function<void(const LoadBundleTaskProgress&)> progress_callback);
 
+  /**
+   * Reads a Firestore `Query` from the local cache, identified by the given
+   * name.
+   *
+   * Named queries are packaged into bundles on the server side (along with the
+   * resulting documents) and loaded into local cache using `LoadBundle`. Once
+   * in the local cache, you can use this method to extract a query by name.
+   *
+   * If a query cannot be found, the returned future will complete with its
+   * `error()` set to a non-zero error code.
+   *
+   * @param query_name The name of the query to read from saved bundles.
+   */
+  virtual Future<Query> NamedQuery(const std::string& query_name);
+
  protected:
   /**
    * Default constructor, to be used only for mocking `Firestore`.

firestore/src/include/firebase/firestore.h

@@ -377,5 +377,21 @@ Future<LoadBundleTaskProgress> FirestoreInternal::LoadBundle(
   return promise.future();
 }
 
+Future<Query> FirestoreInternal::NamedQuery(const std::string& query_name) {
+  auto promise = promise_factory_.CreatePromise<Query>(AsyncApi::kNamedQuery);
+  firestore_core_->GetNamedQuery(
+      query_name,
+      [this, promise](const core::Query& query, bool found) mutable {
+        if (found) {
+          promise.SetValue(MakePublic(api::Query(query, firestore_core_)));
+        } else {
+          promise.SetError(
+              Status(Error::kErrorNotFound, "Named query cannot be found"));
+        }
+      });
+
+  return promise.future();
+}
+
 }  // namespace firestore
 }  // namespace firebase

firestore/src/main/firestore_main.cc

@@ -92,6 +92,7 @@ class FirestoreInternal {
   Future<LoadBundleTaskProgress> LoadBundle(
       const std::string& bundle,
       std::function<void(const LoadBundleTaskProgress&)> progress_callback);
+  Future<Query> NamedQuery(const std::string& query_name);
 
   // Manages the ListenerRegistrationInternal objects.
   void RegisterListenerRegistration(ListenerRegistrationInternal* registration);

firestore/src/main/firestore_main.h

@@ -571,6 +571,8 @@ code.
 -   Changes
     -   Firestore: Fixed a linker error when `DocumentChange::npos` was used.
         ([#474](https://github.com/firebase/firebase-cpp-sdk/pull/474)).
+    -   Firestore: Added `Firestore::NamedQuery` that allows reading the queries
+        used to build a Firestore Data Bundle.
 
 ### 8.0.0
 -   Changes