Skip to content

Roll back PR#4715. #4761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2023
Merged

Roll back PR#4715. #4761

merged 1 commit into from
Mar 9, 2023

Conversation

@ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Mar 9, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@ehsannas ehsannas mentioned this pull request Mar 9, 2023
Merged
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 9, 2023

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.17% (5318bd9) to 44.13% (5a5054d) by -0.04%.

    FilenameBase (5318bd9)Merge (5a5054d)Diff
    LocalStore.java100.00%99.38%-0.62%
    LruGarbageCollector.java97.20%93.46%-3.74%
    ServerTimestamps.java92.00%79.17%-12.83%
    Value.java41.22%40.97%-0.25%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2cx8m2hvPb.html

@tom-andersen tom-andersen self-requested a review March 9, 2023 00:40
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Unit Test Results

   158 files  ±0     158 suites  ±0   1m 42s ⏱️ -5s
1 116 tests  - 1  1 100 ✔️  - 1  16 💤 ±0  0 ❌ ±0 
2 232 runs   - 2  2 200 ✔️  - 2  32 💤 ±0  0 ❌ ±0 

Results for commit 1d75370. ± Comparison against base commit 5318bd9.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 9, 2023

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (5318bd9)Merge (5a5054d)Diff
    aar1.32 MB1.32 MB-35 B (-0.0%)
    apk (release)3.94 MB3.94 MB+56 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qztmUOTQsz.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 9, 2023

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentile5318bd95a5054dDiffSignificant (?)
    p10337 ±26 μs331 ±65 μs-6.27 μs (-1.9%)NO
    p25361 ±54 μs342 ±73 μs-19.0 μs (-5.3%)NO
    p50384 ±65 μs360 ±84 μs-23.4 μs (-6.1%)NO
    p75415 ±84 μs410 ±124 μs-5.32 μs (-1.3%)NO
    p90460 ±97 μs474 ±194 μs+14.1 μs (+3.1%)NO

    20 test runs in comparison
    CommitTest Runs
    5318bd9
    • 2023-03-09_00:05:09.929213_Rbgr
    • 2023-03-09_00:05:09.932161_eoaD
    • 2023-03-09_00:05:09.932185_ExFM
    • 2023-03-09_00:05:09.932194_KRMd
    • 2023-03-09_00:05:09.932213_BrKC
    • 2023-03-09_00:05:09.932221_ribM
    • 2023-03-09_00:05:09.932228_DIIT
    • 2023-03-09_00:05:09.932235_urxk
    • 2023-03-09_00:05:09.932241_POFF
    • 2023-03-09_00:05:09.932248_CMEE
    5a5054d
    • 2023-03-09_00:53:07.476207_Vmab
    • 2023-03-09_00:53:07.486952_BPhD
    • 2023-03-09_00:53:07.486969_PJuZ
    • 2023-03-09_00:53:07.486977_eDAX
    • 2023-03-09_00:53:07.487446_nXQO
    • 2023-03-09_00:53:07.487466_nCyH
    • 2023-03-09_00:53:07.487473_WEha
    • 2023-03-09_00:53:07.487478_XBJk
    • 2023-03-09_00:53:07.487515_VTGf
    • 2023-03-09_00:53:07.487522_UYeL
    redfin-30
    Percentile5318bd95a5054dDiffSignificant (?)
    p10638 ±31 μs621 ±40 μs-17.2 μs (-2.7%)NO
    p25660 ±32 μs635 ±45 μs-24.9 μs (-3.8%)NO
    p50693 ±40 μs658 ±50 μs-34.6 μs (-5.0%)NO
    p75741 ±55 μs689 ±61 μs-51.7 μs (-7.0%)NO
    p90794 ±75 μs734 ±88 μs-59.9 μs (-7.5%)NO

    20 test runs in comparison
    CommitTest Runs
    5318bd9
    • 2023-03-09_00:05:09.929213_Rbgr
    • 2023-03-09_00:05:09.932161_eoaD
    • 2023-03-09_00:05:09.932185_ExFM
    • 2023-03-09_00:05:09.932194_KRMd
    • 2023-03-09_00:05:09.932213_BrKC
    • 2023-03-09_00:05:09.932221_ribM
    • 2023-03-09_00:05:09.932228_DIIT
    • 2023-03-09_00:05:09.932235_urxk
    • 2023-03-09_00:05:09.932241_POFF
    • 2023-03-09_00:05:09.932248_CMEE
    5a5054d
    • 2023-03-09_00:53:07.476207_Vmab
    • 2023-03-09_00:53:07.486952_BPhD
    • 2023-03-09_00:53:07.486969_PJuZ
    • 2023-03-09_00:53:07.486977_eDAX
    • 2023-03-09_00:53:07.487446_nXQO
    • 2023-03-09_00:53:07.487466_nCyH
    • 2023-03-09_00:53:07.487473_WEha
    • 2023-03-09_00:53:07.487478_XBJk
    • 2023-03-09_00:53:07.487515_VTGf
    • 2023-03-09_00:53:07.487522_UYeL

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile5318bd95a5054dDiffSignificant (?)
    p10199 ±11 ms201 ±25 ms+2.21 ms (+1.1%)NO
    p25208 ±17 ms208 ±27 ms+151 μs (+0.1%)NO
    p50220 ±26 ms216 ±32 ms-3.23 ms (-1.5%)NO
    p75231 ±31 ms226 ±37 ms-4.98 ms (-2.2%)NO
    p90245 ±39 ms238 ±47 ms-7.72 ms (-3.1%)NO

    20 test runs in comparison
    CommitTest Runs
    5318bd9
    • 2023-03-09_00:05:09.929213_Rbgr
    • 2023-03-09_00:05:09.932161_eoaD
    • 2023-03-09_00:05:09.932185_ExFM
    • 2023-03-09_00:05:09.932194_KRMd
    • 2023-03-09_00:05:09.932213_BrKC
    • 2023-03-09_00:05:09.932221_ribM
    • 2023-03-09_00:05:09.932228_DIIT
    • 2023-03-09_00:05:09.932235_urxk
    • 2023-03-09_00:05:09.932241_POFF
    • 2023-03-09_00:05:09.932248_CMEE
    5a5054d
    • 2023-03-09_00:53:07.476207_Vmab
    • 2023-03-09_00:53:07.486952_BPhD
    • 2023-03-09_00:53:07.486969_PJuZ
    • 2023-03-09_00:53:07.486977_eDAX
    • 2023-03-09_00:53:07.487446_nXQO
    • 2023-03-09_00:53:07.487466_nCyH
    • 2023-03-09_00:53:07.487473_WEha
    • 2023-03-09_00:53:07.487478_XBJk
    • 2023-03-09_00:53:07.487515_VTGf
    • 2023-03-09_00:53:07.487522_UYeL
    redfin-30
    Percentile5318bd95a5054dDiffSignificant (?)
    p10231 ±3 ms252 ±5 ms+21.1 ms (+9.1%)YES
    p25236 ±3 ms258 ±4 ms+21.4 ms (+9.0%)YES
    p50243 ±3 ms265 ±4 ms+21.4 ms (+8.8%)YES
    p75251 ±3 ms273 ±5 ms+22.2 ms (+8.9%)MAYBE
    p90260 ±4 ms284 ±6 ms+24.4 ms (+9.4%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    5318bd9
    • 2023-03-09_00:05:09.929213_Rbgr
    • 2023-03-09_00:05:09.932161_eoaD
    • 2023-03-09_00:05:09.932185_ExFM
    • 2023-03-09_00:05:09.932194_KRMd
    • 2023-03-09_00:05:09.932213_BrKC
    • 2023-03-09_00:05:09.932221_ribM
    • 2023-03-09_00:05:09.932228_DIIT
    • 2023-03-09_00:05:09.932235_urxk
    • 2023-03-09_00:05:09.932241_POFF
    • 2023-03-09_00:05:09.932248_CMEE
    5a5054d
    • 2023-03-09_00:53:07.476207_Vmab
    • 2023-03-09_00:53:07.486952_BPhD
    • 2023-03-09_00:53:07.486969_PJuZ
    • 2023-03-09_00:53:07.486977_eDAX
    • 2023-03-09_00:53:07.487446_nXQO
    • 2023-03-09_00:53:07.487466_nCyH
    • 2023-03-09_00:53:07.487473_WEha
    • 2023-03-09_00:53:07.487478_XBJk
    • 2023-03-09_00:53:07.487515_VTGf
    • 2023-03-09_00:53:07.487522_UYeL

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zXo6dfbbx6/index.html

@ehsannas ehsannas merged commit 7bbe823 into master Mar 9, 2023
@ehsannas ehsannas deleted the ehsann/rollback-4715 branch March 9, 2023 01:36
@firebase firebase locked and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tom-andersen tom-andersen tom-andersen approved these changes

Assignees

No one assigned

Labels

main-merge-ack size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ehsannas @google-oss-bot @tom-andersen