-
Notifications
You must be signed in to change notification settings - Fork 649
Fix StackOverflowError by deeply nested server-timestamps. #4715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix StackOverflowError by deeply nested server-timestamps. #4715
Conversation
Omit history of server-timestamps to fix StackOverflowError. See: #4702
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @ehsannas, let me know how to resolve |
|
@sk-takahiro-kurebayashi Thanks for your contribution! 🎉 |
|
Looks like I need to roll back this change as there were a few integration test failures that were skipped by the CI in this PR. |
|
I'll look into the failures and fix them as needed. |
|
For now, rolling this PR back via #4761 |
Summary
This PR fixes app crash by
StackOverflowErrorwhile saving the document overlay cache into SQLite database inside of Firestore library.See: #4702
Notes
This PR cannot fix
StackOverflowErrorraised while loading the document overlay cache from SQLite database.To avoid this crash, we can clear persistent storage by
FirebaseFirestore#clearPersistencewhen right after the app launch.