Skip to content

Read release name from release config file. #4567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2023
Merged

Read release name from release config file. #4567

merged 1 commit into from
Jan 19, 2023

Conversation

@rlazo
Copy link
Collaborator

@rlazo rlazo commented Jan 18, 2023

These changes complements the changes introduced in #4565

@rlazo
Read release name from release config file.
7307100 
These changes complements the changes introduced in #4565
@rlazo rlazo requested review from daymxn and emilypgoogle January 18, 2023 05:43
@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 18, 2023

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@rlazo rlazo mentioned this pull request Jan 18, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2023

Unit Test Results

   402 files  ±0     402 suites  ±0   18m 12s ⏱️ -45s
4 761 tests ±0  4 739 ✔️ ±0  22 💤 ±0  0 ❌ ±0 
4 777 runs  ±0  4 755 ✔️ ±0  22 💤 ±0  0 ❌ ±0 

Results for commit 7307100. ± Comparison against base commit fa9536e.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 18, 2023

Size Report 1

Affected Products

  • firebase-appcheck-interop

    TypeBase (fa9536e)Merge (9f7036e)Diff
    apk (aggressive)354 kB358 kB+4.10 kB (+1.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YqQhvC0zUj.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 18, 2023

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.07% (fa9536e) to 50.11% (9f7036e) by +0.04%.

    FilenameBase (fa9536e)Merge (9f7036e)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Mp8euXHMCc.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 18, 2023

Startup Time Report 1

The report is too large (117,107 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kqpL0sdKym/index.html

@rlazo rlazo merged commit f77ea3f into master Jan 19, 2023
@rlazo rlazo deleted the rl.name6767 branch January 19, 2023 00:55
mrober pushed a commit that referenced this pull request Jan 30, 2023
@rlazo @mrober
Read release name from release config file. (#4567)
5e8ee8b 
These changes complements the changes introduced in #4565
@firebase firebase locked and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@emilypgoogle emilypgoogle emilypgoogle approved these changes

@daymxn daymxn Awaiting requested review from daymxn

Assignees

No one assigned

Labels

main-merge-ack no-changelog size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rlazo @google-oss-bot @emilypgoogle