Skip to content

Standardize transaction retries to attempts #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2021
Merged

Standardize transaction retries to attempts #2764

merged 2 commits into from
Jun 25, 2021

Conversation

@thebrianchen
Copy link

@thebrianchen thebrianchen commented Jun 25, 2021

This PR standardizes transaction retry language to use "attempts" rather than "retries" as part of b/147440261

@thebrianchen thebrianchen self-assigned this Jun 25, 2021
@googlebot googlebot added the cla: yes Override cla label Jun 25, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 25, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-firestore

    SDK overall coverage changed from 47.23% (9ab737a) to 47.14% (f59a178a) by -0.10%.

    Filename Base (9ab737a) Head (f59a178a) Diff
    AsyncQueue.java 78.39% 76.88% -1.51%
    FirestoreClient.java 34.96% 30.08% -4.88%
    LruGarbageCollector.java 93.46% 84.11% -9.35%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (f59a178a) is created by Prow via merging commits: 9ab737a 822475c.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 25, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-firestore

    Type Base (9ab737a) Head (f59a178a) Diff
    aar 1.03 MB 1.03 MB +31 B (+0.0%)
    apk (release) 3.19 MB 3.19 MB -12 B (-0.0%)

Test Logs

Notes

Head commit (f59a178a) is created by Prow via merging commits: 9ab737a 822475c.

@thebrianchen
Copy link
Author

thebrianchen commented Jun 25, 2021

/test check-changed

@thebrianchen thebrianchen merged commit 563781c into master Jun 25, 2021
@thebrianchen thebrianchen deleted the bc/tx-attempts branch June 25, 2021 23:38
This was referenced Jun 28, 2021
Merged
Merged
@firebase firebase locked and limited conversation to collaborators Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@thebrianchen thebrianchen

Labels

api: firestore cla: yes Override cla size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thebrianchen @google-oss-bot @schmidt-sebastian @googlebot