Skip to content

Commit c6b9c56

Browse files
Update test and rename customSignalsMap to customSignals
1 parent becb76d commit c6b9c56

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

firebase-config/src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfig.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -658,15 +658,15 @@ private Task<Void> setDefaultsWithStringsMapAsync(Map<String, String> defaultsSt
658658
* <p>The {@code customSignals} parameter should be an instance of {@link CustomSignals}, which
659659
* enforces the allowed types for custom signal values (String, Long or Double).
660660
*
661-
* @param customSignalsMap A dictionary of keys and the values of the custom signals to be set for
661+
* @param customSignals A dictionary of keys and the values of the custom signals to be set for
662662
* the app instance
663663
*/
664664
@NonNull
665-
public Task<Void> setCustomSignals(@NonNull CustomSignals customSignalsMap) {
665+
public Task<Void> setCustomSignals(@NonNull CustomSignals customSignals) {
666666
return Tasks.call(
667667
executor,
668668
() -> {
669-
frcSharedPrefs.setCustomSignals(customSignalsMap.customSignals);
669+
frcSharedPrefs.setCustomSignals(customSignals.customSignals);
670670
return null;
671671
});
672672
}

firebase-config/src/test/java/com/google/firebase/remoteconfig/internal/ConfigSharedPrefsClientTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -374,10 +374,10 @@ public void getCustomSignals_isSet_returnsCustomSignals() {
374374
@Test
375375
public void setCustomSignals_multipleTimes_addsNewSignals() {
376376
Map<String, String> signals1 = ImmutableMap.of("subscription", "premium");
377-
Map<String, String> signals2 = ImmutableMap.of("age", "20");
377+
Map<String, String> signals2 = ImmutableMap.of("age", "20", "subscription", "basic");
378378
sharedPrefsClient.setCustomSignals(signals1);
379379
sharedPrefsClient.setCustomSignals(signals2);
380-
Map<String, String> expectedSignals = ImmutableMap.of("subscription", "premium", "age", "20");
380+
Map<String, String> expectedSignals = ImmutableMap.of("subscription", "basic", "age", "20");
381381
assertThat(sharedPrefsClient.getCustomSignals()).isEqualTo(expectedSignals);
382382
}
383383

0 commit comments

Comments
 (0)