Feedback.

Author: wu-hui

firebase-firestore/src/main/java/com/google/firebase/firestore/MemoryEagerGcSettings.java

@@ -29,11 +29,6 @@ public MemoryEagerGcSettings build() {
     }
   }
 
-  @Override
-  public int hashCode() {
-    return super.hashCode();
-  }
-
   @Override
   public boolean equals(@Nullable Object obj) {
     if (this == obj) return true;

firebase-firestore/src/main/java/com/google/firebase/firestore/MemoryLruGcSettings.java

@@ -1,7 +1,6 @@
 package com.google.firebase.firestore;
 
 import androidx.annotation.NonNull;
-import androidx.annotation.Nullable;
 
 public final class MemoryLruGcSettings implements MemoryGarbageCollectorSettings {
 
@@ -36,16 +35,18 @@ public long getSizeBytes() {
   }
 
   @Override
-  public int hashCode() {
-    return super.hashCode();
+  public boolean equals(Object o) {
+    if (this == o) return true;
+    if (o == null || getClass() != o.getClass()) return false;
+
+    MemoryLruGcSettings that = (MemoryLruGcSettings) o;
+
+    return sizeBytes == that.sizeBytes;
   }
 
   @Override
-  public boolean equals(@Nullable Object obj) {
-    if (this == obj) return true;
-    if (obj == null || getClass() != obj.getClass()) return false;
-
-    return true;
+  public int hashCode() {
+    return (int) (sizeBytes ^ (sizeBytes >>> 32));
   }
 
   @NonNull

firebase-firestore/src/main/java/com/google/firebase/firestore/local/MemoryLruReferenceDelegate.java

@@ -27,7 +27,7 @@
 import java.util.Map;
 
 /** Provides LRU garbage collection functionality for MemoryPersistence. */
-public class MemoryLruReferenceDelegate implements ReferenceDelegate, LruDelegate {
+class MemoryLruReferenceDelegate implements ReferenceDelegate, LruDelegate {
   private final MemoryPersistence persistence;
   private final LocalSerializer serializer;
   private final Map<DocumentKey, Long> orphanedSequenceNumbers;

firebase-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteLruReferenceDelegate.java

@@ -25,7 +25,7 @@
 import java.util.List;
 
 /** Provides LRU functionality for SQLite persistence. */
-public class SQLiteLruReferenceDelegate implements ReferenceDelegate, LruDelegate {
+class SQLiteLruReferenceDelegate implements ReferenceDelegate, LruDelegate {
   /**
    * The batch size for orphaned document GC in `removeOrphanedDocuments()`.
    *

firebase-firestore/src/test/java/com/google/firebase/firestore/spec/SpecTestCase.java

@@ -56,12 +56,11 @@
 import com.google.firebase.firestore.core.QueryListener;
 import com.google.firebase.firestore.core.SyncEngine;
 import com.google.firebase.firestore.local.LocalStore;
+import com.google.firebase.firestore.local.LruDelegate;
 import com.google.firebase.firestore.local.LruGarbageCollector;
-import com.google.firebase.firestore.local.MemoryLruReferenceDelegate;
 import com.google.firebase.firestore.local.Persistence;
 import com.google.firebase.firestore.local.PersistenceTestHelpers;
 import com.google.firebase.firestore.local.QueryPurpose;
-import com.google.firebase.firestore.local.SQLiteLruReferenceDelegate;
 import com.google.firebase.firestore.local.TargetData;
 import com.google.firebase.firestore.model.DocumentKey;
 import com.google.firebase.firestore.model.MutableDocument;
@@ -326,14 +325,9 @@ private void initClient() {
 
     ComponentProvider provider = initializeComponentProvider(configuration, useEagerGcForMemory);
     localPersistence = provider.getPersistence();
-    if (localPersistence.getReferenceDelegate() instanceof SQLiteLruReferenceDelegate) {
+    if (localPersistence.getReferenceDelegate() instanceof LruDelegate) {
       lruGarbageCollector =
-          ((SQLiteLruReferenceDelegate) localPersistence.getReferenceDelegate())
-              .getGarbageCollector();
-    } else if (localPersistence.getReferenceDelegate() instanceof MemoryLruReferenceDelegate) {
-      lruGarbageCollector =
-          ((MemoryLruReferenceDelegate) localPersistence.getReferenceDelegate())
-              .getGarbageCollector();
+          ((LruDelegate) localPersistence.getReferenceDelegate()).getGarbageCollector();
     }
     remoteStore = provider.getRemoteStore();
     localStore = provider.getLocalStore();