Implement setDisplayName() for ProjectManagement class (#19)

* Implement setDisplayName() for ProjectManagement class

* fix integration test to address comment

* Enable promise support for integration test

Author: TrCaM

src/index.d.ts

@@ -813,6 +813,7 @@ declare namespace admin.projectManagement {
     listIosApps(): Promise<admin.projectManagement.IosApp[]>;
     listAppMetadata(): Promise<admin.projectManagement.AppMetadata[]>;
     androidApp(appId: string): admin.projectManagement.AndroidApp;
+    setDisplayName(newDisplayName: string): Promise<void>;
     iosApp(appId: string): admin.projectManagement.IosApp;
     shaCertificate(shaHash: string): admin.projectManagement.ShaCertificate;
     createAndroidApp(

src/project-management/project-management.ts

@@ -159,9 +159,8 @@ export class ProjectManagement implements FirebaseServiceInterface {
   /**
    * Update display name of the project
    */
-  public setDisplayName(displayName: string): Promise<void> {
-    throw new FirebaseProjectManagementError(
-      'service-unavailable', 'This service is not available');
+  public setDisplayName(newDisplayName: string): Promise<void> {
+    return this.requestHandler.setDisplayName(this.resourceName, newDisplayName);
   }
 
   private transformResponseToAppMetadata(responseData: any): AppMetadata[] {

test/integration/project-management.spec.ts

@@ -16,19 +16,25 @@
 
 import * as _ from 'lodash';
 import * as chai from 'chai';
+import * as chaiAsPromised from 'chai-as-promised';
 import * as admin from '../../lib/index';
 import { projectId } from './setup';
 
 const APP_NAMESPACE_PREFIX = 'com.adminsdkintegrationtest.a';
 const APP_NAMESPACE_SUFFIX_LENGTH = 15;
 
 const APP_DISPLAY_NAME_PREFIX = 'Created By Firebase AdminSDK Nodejs Integration Testing ';
+const PROJECT_DISPLAY_NAME_PREFIX = 'Nodejs AdminSDK Testing ';
 const APP_DISPLAY_NAME_SUFFIX_LENGTH = 15;
+const PROJECT_DISPLAY_NAME_SUFFIX_LENGTH = 6;
 
 const SHA_256_HASH = 'aaaaccccaaaaccccaaaaccccaaaaccccaaaaccccaaaaccccaaaaccccaaaacccc';
 
 const expect = chai.expect;
 
+chai.should();
+chai.use(chaiAsPromised);
+
 describe('admin.projectManagement', () => {
 
   let androidApp: admin.projectManagement.AndroidApp;
@@ -75,6 +81,15 @@ describe('admin.projectManagement', () => {
     });
   });
 
+  describe('setDisplayName()', () => {
+    it('successfully set project\'s display name', () => {
+      const newDisplayName = generateUniqueProjectDisplayName();
+      // TODO(caot): verify that project name has been renamed successfully
+      return admin.projectManagement().setDisplayName(newDisplayName)
+        .should.eventually.be.fulfilled;
+    });
+  });
+
   describe('listAppMetadata()', () => {
     it('successfully lists metadata of all apps', () => {
       return admin.projectManagement().listAppMetadata()
@@ -247,6 +262,13 @@ function generateUniqueAppDisplayName() {
   return APP_DISPLAY_NAME_PREFIX + generateRandomString(APP_DISPLAY_NAME_SUFFIX_LENGTH);
 }
 
+/**
+ * @return {string} string that can be used as a unique project display name.
+ */
+function generateUniqueProjectDisplayName() {
+  return PROJECT_DISPLAY_NAME_PREFIX + generateRandomString(PROJECT_DISPLAY_NAME_SUFFIX_LENGTH);
+}
+
 /**
  * @return {boolean} True if the specified appNamespace belongs to these integration tests.
  */

test/unit/project-management/project-management.spec.ts

@@ -511,9 +511,21 @@ describe('ProjectManagement', () => {
   });
 
   describe('setDisplayName', () => {
-    it('should throw service-unavailable error', () => {
-      expect(() => projectManagement.setDisplayName('new project name'))
-          .to.throw('This service is not available');
+    it('should propagate API errors', () => {
+      const stub = sinon
+          .stub(ProjectManagementRequestHandler.prototype, 'setDisplayName')
+          .returns(Promise.reject(EXPECTED_ERROR));
+      stubs.push(stub);
+      return projectManagement.setDisplayName(DISPLAY_NAME_ANDROID)
+          .should.eventually.be.rejected.and.equal(EXPECTED_ERROR);
+    });
+
+    it('should resolve on success', () => {
+      const stub = sinon
+          .stub(ProjectManagementRequestHandler.prototype, 'setDisplayName')
+          .returns(Promise.resolve());
+      stubs.push(stub);
+      return projectManagement.setDisplayName(DISPLAY_NAME_ANDROID).should.eventually.be.fulfilled;
     });
   });
 });