Further deduping code in test

Author: hiranya911

src/test/java/com/google/firebase/messaging/FirebaseMessagingTest.java

@@ -125,12 +125,7 @@ public void testSend() throws Exception {
       String resp = messaging.sendAsync(entry.getKey()).get();
       assertEquals("mock-name", resp);
 
-      assertNotNull(interceptor.getResponse());
-      HttpRequest request = interceptor.getResponse().getRequest();
-      assertEquals("POST", request.getRequestMethod());
-      assertEquals(TEST_FCM_URL, request.getUrl().toString());
-      assertEquals("Bearer test-token", request.getHeaders().getAuthorization());
-
+      HttpRequest request = checkRequestHeader(interceptor);
       checkRequest(request, ImmutableMap.<String, Object>of("message", entry.getValue()));
     }
   }
@@ -149,26 +144,11 @@ public void testSendDryRun() throws Exception {
       String resp = messaging.sendAsync(entry.getKey(), true).get();
       assertEquals("mock-name", resp);
 
-      assertNotNull(interceptor.getResponse());
-      HttpRequest request = interceptor.getResponse().getRequest();
-      assertEquals("POST", request.getRequestMethod());
-      assertEquals(TEST_FCM_URL, request.getUrl().toString());
-      assertEquals("Bearer test-token", request.getHeaders().getAuthorization());
-
+      HttpRequest request = checkRequestHeader(interceptor);
       checkRequest(request, ImmutableMap.of("message", entry.getValue(), "validate_only", true));
     }
   }
 
-  private static void checkRequest(
-      HttpRequest request, Map<String, Object> expected) throws IOException {
-    ByteArrayOutputStream out = new ByteArrayOutputStream();
-    request.getContent().writeTo(out);
-    JsonParser parser = Utils.getDefaultJsonFactory().createJsonParser(out.toString());
-    Map<String, Object> parsed = new HashMap<>();
-    parser.parseAndClose(parsed);
-    assertEquals(expected, parsed);
-  }
-
   @Test
   public void testSendError() throws Exception {
     MockLowLevelHttpResponse response = new MockLowLevelHttpResponse();
@@ -188,7 +168,7 @@ public void testSendError() throws Exception {
             error.getMessage());
         assertTrue(error.getCause() instanceof HttpResponseException);
       }
-      checkMessagingRequest(interceptor);
+      checkRequestHeader(interceptor);
     }
   }
 
@@ -211,7 +191,7 @@ public void testSendErrorWithDetails() throws Exception {
         assertEquals("test error", error.getMessage());
         assertTrue(error.getCause() instanceof HttpResponseException);
       }
-      checkMessagingRequest(interceptor);
+      checkRequestHeader(interceptor);
     }
   }
 
@@ -243,7 +223,8 @@ public void testSubscribe() throws Exception {
 
     TopicManagementResponse result = messaging.subscribeToTopicAsync(
         ImmutableList.of("id1", "id2"), "test-topic").get();
-    checkTopicManagementCall(TEST_IID_SUBSCRIBE_URL, result, interceptor);
+    HttpRequest request = checkTopicManagementRequestHeader(interceptor, TEST_IID_SUBSCRIBE_URL);
+    checkTopicManagementRequest(request, result);
   }
 
   @Test
@@ -265,11 +246,7 @@ public void testSubscribeError() throws Exception {
         assertTrue(error.getCause() instanceof HttpResponseException);
       }
 
-      assertNotNull(interceptor.getResponse());
-      HttpRequest request = interceptor.getResponse().getRequest();
-      assertEquals("POST", request.getRequestMethod());
-      assertEquals(TEST_IID_SUBSCRIBE_URL, request.getUrl().toString());
-      assertEquals("Bearer test-token", request.getHeaders().getAuthorization());
+      checkTopicManagementRequestHeader(interceptor, TEST_IID_SUBSCRIBE_URL);
     }
   }
 
@@ -301,7 +278,8 @@ public void testUnsubscribe() throws Exception {
 
     TopicManagementResponse result = messaging.unsubscribeFromTopicAsync(
         ImmutableList.of("id1", "id2"), "test-topic").get();
-    checkTopicManagementCall(TEST_IID_UNSUBSCRIBE_URL, result, interceptor);
+    HttpRequest request = checkTopicManagementRequestHeader(interceptor, TEST_IID_UNSUBSCRIBE_URL);
+    checkTopicManagementRequest(request, result);
   }
 
   @Test
@@ -323,11 +301,7 @@ public void testUnsubscribeError() throws Exception {
         assertTrue(error.getCause() instanceof HttpResponseException);
       }
 
-      assertNotNull(interceptor.getResponse());
-      HttpRequest request = interceptor.getResponse().getRequest();
-      assertEquals("POST", request.getRequestMethod());
-      assertEquals(TEST_IID_UNSUBSCRIBE_URL, request.getUrl().toString());
-      assertEquals("Bearer test-token", request.getHeaders().getAuthorization());
+      checkTopicManagementRequestHeader(interceptor, TEST_IID_UNSUBSCRIBE_URL);
     }
   }
 
@@ -364,29 +338,33 @@ private static FirebaseMessaging initDefaultMessaging() {
     return FirebaseMessaging.getInstance(app);
   }
 
-  private static void checkMessagingRequest(TestResponseInterceptor interceptor) {
+  private static void checkRequest(
+      HttpRequest request, Map<String, Object> expected) throws IOException {
+    ByteArrayOutputStream out = new ByteArrayOutputStream();
+    request.getContent().writeTo(out);
+    JsonParser parser = Utils.getDefaultJsonFactory().createJsonParser(out.toString());
+    Map<String, Object> parsed = new HashMap<>();
+    parser.parseAndClose(parsed);
+    assertEquals(expected, parsed);
+  }
+
+  private static HttpRequest checkRequestHeader(TestResponseInterceptor interceptor) {
     assertNotNull(interceptor.getResponse());
     HttpRequest request = interceptor.getResponse().getRequest();
     assertEquals("POST", request.getRequestMethod());
     assertEquals(TEST_FCM_URL, request.getUrl().toString());
     assertEquals("Bearer test-token", request.getHeaders().getAuthorization());
+    return request;
   }
 
-  private static void checkTopicManagementCall(String url,
-      TopicManagementResponse result, TestResponseInterceptor interceptor) throws IOException {
+  private static void checkTopicManagementRequest(
+      HttpRequest request, TopicManagementResponse result) throws IOException {
     assertEquals(1, result.getSuccessCount());
     assertEquals(1, result.getFailureCount());
     assertEquals(1, result.getErrors().size());
     assertEquals(1, result.getErrors().get(0).getIndex());
     assertEquals("unknown-error", result.getErrors().get(0).getReason());
 
-    assertNotNull(interceptor.getResponse());
-    HttpRequest request = interceptor.getResponse().getRequest();
-    assertEquals("POST", request.getRequestMethod());
-    assertEquals(url, request.getUrl().toString());
-    assertEquals("Bearer test-token", request.getHeaders().getAuthorization());
-    assertEquals("true", request.getHeaders().get("access_token_auth"));
-
     ByteArrayOutputStream out = new ByteArrayOutputStream();
     request.getContent().writeTo(out);
     Map<String, Object> parsed = new HashMap<>();
@@ -397,6 +375,16 @@ private static void checkTopicManagementCall(String url,
     assertEquals(ImmutableList.of("id1", "id2"), parsed.get("registration_tokens"));
   }
 
+  private static HttpRequest checkTopicManagementRequestHeader(
+      TestResponseInterceptor interceptor, String expectedUrl) {
+    assertNotNull(interceptor.getResponse());
+    HttpRequest request = interceptor.getResponse().getRequest();
+    assertEquals("POST", request.getRequestMethod());
+    assertEquals(expectedUrl, request.getUrl().toString());
+    assertEquals("Bearer test-token", request.getHeaders().getAuthorization());
+    return request;
+  }
+
   private static class TopicMgtArgs {
     private final List<String> registrationTokens;
     private final String topic;