Skip to content

Conversation

@abdonkov
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes

  • Added the ability to open a directory with a selected item from the command line
    • Introduced "Select" command argument, through which the name of the file or folder to select on startup can be provided (selected item is part of the opened directory which has to be provided with the "Directory" command argument)

Known issues

  • Details Layout View doesn't scroll into view the selected item (part of a different bug - first keyboard letter press in this layout, doesn't scroll into view either)

Validation
How did you test these changes?

  • Built and ran the app

Example usage:
files.exe -Direcroty "D:\Downloads" -Select "image.png"
files.exe -Directory "D:\Downloads" -Select "Some Folder"

@yaira2 yaira2 requested a review from gave92 October 19, 2021 17:39
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Oct 19, 2021
@gave92
Copy link
Member

gave92 commented Oct 19, 2021

Looks pretty good @abdonkov, thanks! I've pushed a small change to add support for the syntax files.exe -select c:\users\smth\documents\file.docx which is easier and more closely resembles explorer's.

@abdonkov
Copy link
Contributor Author

Yeah that looks great, more options is always better :)

@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Oct 20, 2021
Copy link
Member

@gave92 gave92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 222c916 into files-community:main Oct 20, 2021
@yaira2
Copy link
Member

yaira2 commented Oct 20, 2021

@abdonkov thank you!

@neoOpus
Copy link

neoOpus commented May 29, 2022

This works but only on small folder with few files, on my Download folder which contains hundreds of files it just open the folder but doesn't select the file... (please fix)

@gave92
Copy link
Member

gave92 commented May 29, 2022

@neoOpus could you confirm whether the file gets selected, the issue actually being that the list does not scroll down to it?

@neoOpus
Copy link

neoOpus commented May 29, 2022

@neoOpus could you confirm whether the file gets selected, the issue actually being that the list does not scroll down to it?

You are right, it gets selected but doesn't scroll to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opening the folder containing the file from command line.

4 participants