From f99905602c426be26057f9f1f67d444b3391b033 Mon Sep 17 00:00:00 2001
From: Chris Morgan <me@chrismorgan.info>
Date: Fri, 24 Aug 2018 13:31:17 +1000
Subject: [PATCH] =?UTF-8?q?Be=20case-sensitive=20about=20responding=20to?=
 =?UTF-8?q?=20=E2=80=9CRFC=E2=80=9D?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

I expect “rfc\d+” to be entirely false positives.

This is probably most notable in the MIME type “message/rfc822” which
crops up fairly often in the email space. If this approach of requiring
capital “RFC” is considered too radical, an alternative would be to
specifically not respond to “rfc822” (case sensitive). But that’s more
work to implement.
---
 lib/Synergy/Reactor/RFC.pm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/Synergy/Reactor/RFC.pm b/lib/Synergy/Reactor/RFC.pm
index e47a2443..2692727a 100644
--- a/lib/Synergy/Reactor/RFC.pm
+++ b/lib/Synergy/Reactor/RFC.pm
@@ -15,7 +15,7 @@ sub listener_specs {
     name      => 'rfc-mention',
     method    => 'handle_rfc',
     predicate => sub ($self, $e) {
-      return unless $e->text =~ /RFC\s*[0-9]+/i; },
+      return unless $e->text =~ /RFC\s*[0-9]+/; },
   };
 }
 
@@ -52,7 +52,7 @@ sub handle_rfc ($self, $event) {
   my ($num, $link) = $self->extract_rfc($text);
 
   unless (defined $num && defined $link) {
-    if ($event->was_targeted && $event->text =~ /\A\s* RFC \s* [0-9]+/ix) {
+    if ($event->was_targeted && $event->text =~ /\A\s* RFC \s* [0-9]+/x) {
       $event->reply("Oddly, I could not figure out what RFC you meant");
 
       $event->mark_handled;
@@ -62,7 +62,7 @@ sub handle_rfc ($self, $event) {
   }
 
   my $solo_cmd = $event->was_targeted
-              && $event->text =~ /\A\s* RFC \s* [0-9]+ \s*/ix;
+              && $event->text =~ /\A\s* RFC \s* [0-9]+ \s*/x;
 
   $event->mark_handled if $solo_cmd;
 
@@ -118,7 +118,7 @@ sub handle_rfc ($self, $event) {
 my $sec_dig = qr/[0-9]+(?:[.-])?(?:[0-9]+)?/;
 
 sub extract_rfc ($self, $text) {
-  return unless $text =~ s/RFC\s*([0-9]+)//ig;
+  return unless $text =~ s/RFC\s*([0-9]+)//g;
 
   my $num = $1;