fix: referenceError on schema validation failure. (#164)

* fix: check the initialization of the client in onSend handler preventing referenceError on schema validation failure.

* remove unused and useless code

Co-authored-by: Manuel Spigolon <[email protected]>

* refactor: avoiding empty return statement

---------

Co-authored-by: Luca Rainone <[email protected]>
Co-authored-by: Manuel Spigolon <[email protected]>

Author: 3 people

index.js

@@ -171,12 +171,14 @@ function fastifyPostgres (fastify, options, next) {
 
     const onSend = async (req) => {
       const requestClient = extractRequestClient(req, transact)
-      try {
-        if (!req[transactionFailedSymbol]) {
-          await requestClient.query('COMMIT')
+      if (requestClient) {
+        try {
+          if (!req[transactionFailedSymbol]) {
+            await requestClient.query('COMMIT')
+          }
+        } finally {
+          requestClient.release()
         }
-      } finally {
-        requestClient.release()
       }
     }
 

test/req-initialization.test.js

@@ -143,6 +143,38 @@ test('When we use the fastify-postgres transaction route option', t => {
     t.equal(extractUserCount(response), 0)
   })
 
+  t.test('Should work properly with `schema` option and validation failure', async t => {
+    const fastify = Fastify()
+    t.teardown(() => fastify.close())
+
+    await fastify.register(fastifyPostgres, {
+      connectionString
+    })
+
+    fastify.post('/schema-validation', {
+      schema: {
+        body: {
+          type: 'object',
+          properties: {
+            hello: { type: 'string' }
+          },
+          required: ['hello']
+        }
+      },
+      pg: { transact: true }
+    }, async (req, reply) => {
+      t.fail('should never execute the handler')
+    })
+
+    const response = await fastify.inject({
+      url: '/schema-validation',
+      method: 'POST',
+      body: { notValid: 'json input' }
+    })
+    t.not(response.body, 'never success')
+    t.equal(response.json().code, 'FST_ERR_VALIDATION')
+  })
+
   t.end()
 })