From 56fcdfd2830f16f1ce5ebfce371e8434c803b86d Mon Sep 17 00:00:00 2001 From: Sebastian Markbage Date: Wed, 15 Oct 2025 11:17:09 -0400 Subject: [PATCH] The bridge event types should only be defined in one direction --- packages/react-devtools-shared/src/bridge.js | 21 +++++++++---------- .../Components/InspectHostNodesToggle.js | 2 +- 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/packages/react-devtools-shared/src/bridge.js b/packages/react-devtools-shared/src/bridge.js index b6229192c23b1..3162dc215ff0a 100644 --- a/packages/react-devtools-shared/src/bridge.js +++ b/packages/react-devtools-shared/src/bridge.js @@ -217,10 +217,15 @@ export type BackendEvents = { selectElement: [number], shutdown: [], stopInspectingHost: [boolean], - syncSelectionFromBuiltinElementsPanel: [], syncSelectionToBuiltinElementsPanel: [], unsupportedRendererVersion: [], + extensionComponentsPanelShown: [], + extensionComponentsPanelHidden: [], + + resumeElementPolling: [], + pauseElementPolling: [], + // React Native style editor plug-in. isNativeStyleEditorSupported: [ {isSupported: boolean, validAttributes: ?$ReadOnlyArray}, @@ -240,8 +245,6 @@ type FrontendEvents = { clearWarningsForElementID: [ElementAndRendererID], copyElementPath: [CopyElementPathParams], deletePath: [DeletePath], - extensionComponentsPanelShown: [], - extensionComponentsPanelHidden: [], getBackendVersion: [], getBridgeProtocol: [], getIfHasUnsupportedRendererVersion: [], @@ -265,7 +268,7 @@ type FrontendEvents = { shutdown: [], startInspectingHost: [], startProfiling: [StartProfilingParams], - stopInspectingHost: [boolean], + stopInspectingHost: [], scrollToHostInstance: [ScrollToHostInstance], stopProfiling: [], storeAsGlobal: [StoreAsGlobalParams], @@ -275,6 +278,8 @@ type FrontendEvents = { viewAttributeSource: [ViewAttributeSourceParams], viewElementSource: [ElementAndRendererID], + syncSelectionFromBuiltinElementsPanel: [], + // React Native style editor plug-in. NativeStyleEditor_measure: [ElementAndRendererID], NativeStyleEditor_renameAttribute: [NativeStyleEditor_RenameAttributeParams], @@ -295,19 +300,13 @@ type FrontendEvents = { overrideProps: [OverrideValue], overrideState: [OverrideValue], - resumeElementPolling: [], - pauseElementPolling: [], - getHookSettings: [], }; class Bridge< OutgoingEvents: Object, IncomingEvents: Object, -> extends EventEmitter<{ - ...IncomingEvents, - ...OutgoingEvents, -}> { +> extends EventEmitter { _isShutdown: boolean = false; _messageQueue: Array = []; _scheduledFlush: boolean = false; diff --git a/packages/react-devtools-shared/src/devtools/views/Components/InspectHostNodesToggle.js b/packages/react-devtools-shared/src/devtools/views/Components/InspectHostNodesToggle.js index 2f2b9e9e91d0a..17a7b049cc9b3 100644 --- a/packages/react-devtools-shared/src/devtools/views/Components/InspectHostNodesToggle.js +++ b/packages/react-devtools-shared/src/devtools/views/Components/InspectHostNodesToggle.js @@ -26,7 +26,7 @@ export default function InspectHostNodesToggle(): React.Node { logEvent({event_name: 'inspect-element-button-clicked'}); bridge.send('startInspectingHost'); } else { - bridge.send('stopInspectingHost', false); + bridge.send('stopInspectingHost'); } }, [bridge],