From c6d64f17843b884014ac76c870581c31f57fa7bf Mon Sep 17 00:00:00 2001 From: saikat Date: Thu, 1 Oct 2020 04:36:37 +0530 Subject: [PATCH 1/2] update url in the check to reactjs.org for the development version cheat as the old facebook.github.io/react always redirects to reactjs.org --- packages/react-devtools-extensions/src/background.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-devtools-extensions/src/background.js b/packages/react-devtools-extensions/src/background.js index 389ca1310a910..eea4a18579201 100644 --- a/packages/react-devtools-extensions/src/background.js +++ b/packages/react-devtools-extensions/src/background.js @@ -99,7 +99,7 @@ chrome.runtime.onMessage.addListener((request, sender) => { // display a custom default popup when React is *not* detected. // It is specified in the manifest. let reactBuildType = request.reactBuildType; - if (sender.url.indexOf('facebook.github.io/react') !== -1) { + if (sender.url.indexOf('reactjs.org') !== -1) { // Cheat: We use the development version on the website because // it is better for interactive examples. However we're going // to get misguided bug reports if the extension highlights it From d61f70964efd0bf48d6ff9a04eb833db6987f6ff Mon Sep 17 00:00:00 2001 From: saikat Date: Thu, 1 Oct 2020 12:10:07 +0530 Subject: [PATCH 2/2] Remove dead code as facebook.github.io/react always redirects to reactjs.org, which has prod version of react. so removing this check --- .../react-devtools-extensions/src/background.js | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/packages/react-devtools-extensions/src/background.js b/packages/react-devtools-extensions/src/background.js index eea4a18579201..1a8302c2b1dfd 100644 --- a/packages/react-devtools-extensions/src/background.js +++ b/packages/react-devtools-extensions/src/background.js @@ -98,18 +98,7 @@ chrome.runtime.onMessage.addListener((request, sender) => { // We use browserAction instead of pageAction because this lets us // display a custom default popup when React is *not* detected. // It is specified in the manifest. - let reactBuildType = request.reactBuildType; - if (sender.url.indexOf('reactjs.org') !== -1) { - // Cheat: We use the development version on the website because - // it is better for interactive examples. However we're going - // to get misguided bug reports if the extension highlights it - // as using the dev version. We're just going to special case - // our own documentation and cheat. It is acceptable to use dev - // version of React in React docs, but not in any other case. - reactBuildType = 'production'; - } - - setIconAndPopup(reactBuildType, sender.tab.id); + setIconAndPopup(request.reactBuildType, sender.tab.id); } } });