Skip to content

Commit efeaa93

Browse files
committed
make parseHookNames a separate webpack module
1 parent 8258361 commit efeaa93

File tree

3 files changed

+21
-24
lines changed

3 files changed

+21
-24
lines changed

packages/react-devtools-extensions/src/main.js

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import {
1212
getSavedComponentFilters,
1313
getShowInlineWarningsAndErrors,
1414
} from 'react-devtools-shared/src/utils';
15-
import {parseHookNames, purgeCachedMetadata} from './parseHookNames';
1615
import {
1716
localStorageGetItem,
1817
localStorageRemoveItem,
@@ -210,23 +209,24 @@ function createPanelIfReactLoaded() {
210209

211210
render = (overrideTab = mostRecentOverrideTab) => {
212211
mostRecentOverrideTab = overrideTab;
213-
214-
root.render(
215-
createElement(DevTools, {
216-
bridge,
217-
browserTheme: getBrowserTheme(),
218-
componentsPortalContainer,
219-
enabledInspectedElementContextMenu: true,
220-
loadHookNames: parseHookNames,
221-
overrideTab,
222-
profilerPortalContainer,
223-
purgeCachedHookNamesMetadata: purgeCachedMetadata,
224-
showTabBar: false,
225-
store,
226-
warnIfUnsupportedVersionDetected: true,
227-
viewAttributeSourceFunction,
228-
viewElementSourceFunction,
229-
}),
212+
import('./parseHookNames').then(
213+
({parseHookNames, purgeCachedMetadata}) => {
214+
createElement(DevTools, {
215+
bridge,
216+
browserTheme: getBrowserTheme(),
217+
componentsPortalContainer,
218+
enabledInspectedElementContextMenu: true,
219+
loadHookNames: parseHookNames,
220+
overrideTab,
221+
profilerPortalContainer,
222+
purgeCachedHookNamesMetadata: purgeCachedMetadata,
223+
showTabBar: false,
224+
store,
225+
warnIfUnsupportedVersionDetected: true,
226+
viewAttributeSourceFunction,
227+
viewElementSourceFunction,
228+
});
229+
},
230230
);
231231
};
232232

packages/react-devtools-extensions/src/parseHookNames/index.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,13 @@
1212
// This file uses workerize to load ./parseHookNames.worker as a webworker and instanciates it,
1313
// exposing flow typed functions that can be used on other files.
1414

15-
import * as parseHookNamesModule from './parseHookNames';
1615
import WorkerizedParseHookNames from './parseHookNames.worker';
17-
18-
type ParseHookNamesModule = typeof parseHookNamesModule;
16+
import typeof * as ParseHookNamesModule from './parseHookNames';
1917

2018
// $FlowFixMe
2119
const wasmMappingsURL = chrome.extension.getURL('mappings.wasm');
2220

23-
const workerizedParseHookNames: ParseHookNamesModule = window.Worker
24-
? WorkerizedParseHookNames()
25-
: parseHookNamesModule;
21+
const workerizedParseHookNames: ParseHookNamesModule = WorkerizedParseHookNames();
2622

2723
type ParseHookNames = $PropertyType<ParseHookNamesModule, 'parseHookNames'>;
2824

packages/react-devtools-extensions/webpack.config.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ module.exports = {
4141
},
4242
output: {
4343
path: __dirname + '/build',
44+
publicPath: '/build/',
4445
filename: '[name].js',
4546
},
4647
node: {

0 commit comments

Comments
 (0)