Skip to content

Commit e649dbe

Browse files
committed
Switch to new ReactFiberScheduler implementation
Sets the `enableNewScheduler` feature flag to true. `yarn test` now runs against the new implementation, so use `yarn test-old-scheduler` to test the old implementation. Both commands will run in CI, in case we need to revert.
1 parent fc0d30e commit e649dbe

11 files changed

+11
-11
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@
102102
"test": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.source.js",
103103
"test-persistent": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.source-persistent.js",
104104
"test-fire": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.source-fire.js",
105-
"test-new-scheduler": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.source-new-scheduler.js",
105+
"test-old-scheduler": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.source-old-scheduler.js",
106106
"test-prod": "cross-env NODE_ENV=production jest --config ./scripts/jest/config.source.js",
107107
"test-fire-prod": "cross-env NODE_ENV=production jest --config ./scripts/jest/config.source-fire.js",
108108
"test-prod-build": "yarn test-build-prod",

packages/shared/ReactFeatureFlags.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,4 +67,4 @@ export const enableEventAPI = false;
6767

6868
// Enables rewritten version of ReactFiberScheduler. Added in case we need to
6969
// quickly revert it.
70-
export const enableNewScheduler = false;
70+
export const enableNewScheduler = true;

packages/shared/forks/ReactFeatureFlags.native-fb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export const replayFailedUnitOfWorkWithInvokeGuardedCallback = __DEV__;
3131
export const warnAboutDeprecatedLifecycles = true;
3232
export const warnAboutDeprecatedSetNativeProps = true;
3333
export const enableEventAPI = false;
34-
export const enableNewScheduler = false;
34+
export const enableNewScheduler = true;
3535

3636
// Only used in www builds.
3737
export function addUserTimingListener() {

packages/shared/forks/ReactFeatureFlags.native-oss.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export const warnAboutShorthandPropertyCollision = false;
2828
export const enableSchedulerDebugging = false;
2929
export const warnAboutDeprecatedSetNativeProps = false;
3030
export const enableEventAPI = false;
31-
export const enableNewScheduler = false;
31+
export const enableNewScheduler = true;
3232

3333
// Only used in www builds.
3434
export function addUserTimingListener() {

packages/shared/forks/ReactFeatureFlags.persistent.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export const warnAboutShorthandPropertyCollision = false;
2828
export const enableSchedulerDebugging = false;
2929
export const warnAboutDeprecatedSetNativeProps = false;
3030
export const enableEventAPI = false;
31-
export const enableNewScheduler = false;
31+
export const enableNewScheduler = true;
3232

3333
// Only used in www builds.
3434
export function addUserTimingListener() {

packages/shared/forks/ReactFeatureFlags.test-renderer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export const warnAboutShorthandPropertyCollision = false;
2828
export const enableSchedulerDebugging = false;
2929
export const warnAboutDeprecatedSetNativeProps = false;
3030
export const enableEventAPI = false;
31-
export const enableNewScheduler = false;
31+
export const enableNewScheduler = true;
3232

3333
// Only used in www builds.
3434
export function addUserTimingListener() {

packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export const warnAboutDeprecatedSetNativeProps = false;
2626
export const disableJavaScriptURLs = false;
2727
export const disableYielding = false;
2828
export const enableEventAPI = true;
29-
export const enableNewScheduler = false;
29+
export const enableNewScheduler = true;
3030

3131
// Only used in www builds.
3232
export function addUserTimingListener() {

packages/shared/forks/ReactFeatureFlags.www.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export const enableSuspenseServerRenderer = true;
4242
// I've chosen to make this a static flag instead of a dynamic flag controlled
4343
// by a GK so that it doesn't increase bundle size. It should still be easy
4444
// to rollback by reverting the commit that turns this on.
45-
export const enableNewScheduler = false;
45+
export const enableNewScheduler = true;
4646

4747
let refCount = 0;
4848
export function addUserTimingListener() {

scripts/circleci/test_entry_point.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ if [ $((0 % CIRCLE_NODE_TOTAL)) -eq "$CIRCLE_NODE_INDEX" ]; then
1111
COMMANDS_TO_RUN+=('node ./scripts/tasks/flow-ci')
1212
COMMANDS_TO_RUN+=('node ./scripts/tasks/eslint')
1313
COMMANDS_TO_RUN+=('yarn test --maxWorkers=2')
14-
COMMANDS_TO_RUN+=('yarn test-new-scheduler --maxWorkers=2')
14+
COMMANDS_TO_RUN+=('yarn test-old-scheduler --maxWorkers=2')
1515
COMMANDS_TO_RUN+=('yarn test-persistent --maxWorkers=2')
1616
COMMANDS_TO_RUN+=('./scripts/circleci/check_license.sh')
1717
COMMANDS_TO_RUN+=('./scripts/circleci/check_modules.sh')

scripts/jest/config.source-new-scheduler.js renamed to scripts/jest/config.source-old-scheduler.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const baseConfig = require('./config.base');
55
module.exports = Object.assign({}, baseConfig, {
66
setupFiles: [
77
...baseConfig.setupFiles,
8-
require.resolve('./setupNewScheduler.js'),
8+
require.resolve('./setupOldScheduler.js'),
99
require.resolve('./setupHostConfigs.js'),
1010
],
1111
});

0 commit comments

Comments
 (0)