Skip to content

Commit 9fc994c

Browse files
author
Brian Vaughn
committed
DevTools: Ignore multiple sourceMappingUrls for external source maps
Added an edge case regression test and bugfix.
1 parent 14bac61 commit 9fc994c

File tree

12 files changed

+198
-33
lines changed

12 files changed

+198
-33
lines changed
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
/**
2+
* Copyright (c) Facebook, Inc. and its affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
import React, {useState} from 'react';
11+
12+
// ?sourceMappingURL=([^\s'"]+)/gm
13+
14+
export function Component() {
15+
const [count, setCount] = useState(0);
16+
17+
return (
18+
<div>
19+
<p>You clicked {count} times</p>
20+
<button onClick={() => setCount(count + 1)}>Click me</button>
21+
</div>
22+
);
23+
}

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/bundle/index.js

Lines changed: 19 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/bundle/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/external/ContainingStringSourceMappingURL.js

Lines changed: 29 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/external/ContainingStringSourceMappingURL.js.map

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/external/index.js

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/external/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/inline/ContainingStringSourceMappingURL.js

Lines changed: 29 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/inline/index.js

Lines changed: 9 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
export {Component as ComponentWithCustomHook} from './ComponentWithCustomHook';
1111
export {Component as ComponentWithExternalCustomHooks} from './ComponentWithExternalCustomHooks';
1212
export {Component as ComponentWithMultipleHooksPerLine} from './ComponentWithMultipleHooksPerLine';
13+
export {Component as ContainingStringSourceMappingURL} from './ContainingStringSourceMappingURL';
1314
export {Component as Example} from './Example';
1415
export {Component as InlineRequire} from './InlineRequire';
1516
import * as ToDoList from './ToDoList';

0 commit comments

Comments
 (0)