Skip to content

Commit 9dcb541

Browse files
author
Brian Vaughn
committed
Don't inject timeline hooks unless React supports profiling
1 parent 790b524 commit 9dcb541

File tree

2 files changed

+20
-10
lines changed

2 files changed

+20
-10
lines changed

packages/react-reconciler/src/ReactFiberDevToolsHook.new.js

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,16 @@ export function injectInternals(internals: Object): boolean {
7474
return true;
7575
}
7676
try {
77-
rendererID = hook.inject({
78-
...internals,
79-
getLaneLabelMap,
80-
injectProfilingHooks,
81-
});
77+
if (enableSchedulingProfiler) {
78+
internals = {
79+
...internals,
80+
getLaneLabelMap,
81+
injectProfilingHooks,
82+
};
83+
}
84+
85+
rendererID = hook.inject(internals);
86+
8287
// We have successfully injected, so now it is safe to set up hooks.
8388
injectedHook = hook;
8489
} catch (err) {

packages/react-reconciler/src/ReactFiberDevToolsHook.old.js

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,16 @@ export function injectInternals(internals: Object): boolean {
7474
return true;
7575
}
7676
try {
77-
rendererID = hook.inject({
78-
...internals,
79-
getLaneLabelMap,
80-
injectProfilingHooks,
81-
});
77+
if (enableSchedulingProfiler) {
78+
internals = {
79+
...internals,
80+
getLaneLabelMap,
81+
injectProfilingHooks,
82+
};
83+
}
84+
85+
rendererID = hook.inject(internals);
86+
8287
// We have successfully injected, so now it is safe to set up hooks.
8388
injectedHook = hook;
8489
} catch (err) {

0 commit comments

Comments
 (0)