fixes

Author: rickhanlonii

packages/react-dom-bindings/src/client/ReactDOMComponent.js

@@ -2485,43 +2485,41 @@ function diffHydratedGenericElement(
       case 'src':
       case 'href':
         if (
+          __DEV__ &&
           value === '' &&
           // <a href=""> is fine for "reload" links.
           !(tag === 'a' && propKey === 'href') &&
           !(tag === 'object' && propKey === 'data')
         ) {
-          if (__DEV__) {
-            if (propKey === 'src') {
-              console.error(
-                'An empty string ("") was passed to the %s attribute. ' +
-                  'This may cause the browser to download the whole page again over the network. ' +
-                  'To fix this, either do not render the element at all ' +
-                  'or pass null to %s instead of an empty string.',
-                propKey,
-                propKey,
-              );
-            } else {
-              console.error(
-                'An empty string ("") was passed to the %s attribute. ' +
-                  'To fix this, either do not render the element at all ' +
-                  'or pass null to %s instead of an empty string.',
-                propKey,
-                propKey,
-              );
-            }
-            continue;
+          if (propKey === 'src') {
+            console.error(
+              'An empty string ("") was passed to the %s attribute. ' +
+                'This may cause the browser to download the whole page again over the network. ' +
+                'To fix this, either do not render the element at all ' +
+                'or pass null to %s instead of an empty string.',
+              propKey,
+              propKey,
+            );
+          } else {
+            console.error(
+              'An empty string ("") was passed to the %s attribute. ' +
+                'To fix this, either do not render the element at all ' +
+                'or pass null to %s instead of an empty string.',
+              propKey,
+              propKey,
+            );
           }
-        } else {
-          hydrateSanitizedAttribute(
-            domElement,
-            propKey,
-            propKey,
-            value,
-            extraAttributes,
-            serverDifferences,
-          );
           continue;
         }
+        hydrateSanitizedAttribute(
+          domElement,
+          propKey,
+          propKey,
+          value,
+          extraAttributes,
+          serverDifferences,
+        );
+        continue;
       case 'action':
       case 'formAction': {
         const serverValue = domElement.getAttribute(propKey);

packages/react-dom/src/__tests__/ReactDOMServerIntegrationAttributes-test.js

@@ -62,22 +62,21 @@ describe('ReactDOMServerIntegration', () => {
         expect(e.getAttribute('href')).toBe('');
       });
 
-      describe.only('test', () => {
-        itRenders('empty href on other tags', async render => {
-          const e = await render(
-            // <link href="" /> would be more sensible.
-            // However, that results in a hydration warning as well.
-            // Our test helpers do not support different error counts for initial
-            // server render and hydration.
-            // The number of errors on the server need to be equal to the number of
-            // errors during hydration.
-            // So we use a <div> instead.
-            <div href="" />,
-            1,
-          );
-          expect(e.getAttribute('href')).toBe(null);
-        });
+      itRenders('empty href on other tags', async render => {
+        const e = await render(
+          // <link href="" /> would be more sensible.
+          // However, that results in a hydration warning as well.
+          // Our test helpers do not support different error counts for initial
+          // server render and hydration.
+          // The number of errors on the server need to be equal to the number of
+          // errors during hydration.
+          // So we use a <div> instead.
+          <div href="" />,
+          1,
+        );
+        expect(e.getAttribute('href')).toBe(null);
       });
+
       itRenders('no string prop with true value', async render => {
         const e = await render(<a href={true} />, 1);
         expect(e.hasAttribute('href')).toBe(false);