Skip to content

Commit 9d8854e

Browse files
committed
Fix date mismatch
1 parent 84f7ab8 commit 9d8854e

File tree

2 files changed

+16
-4
lines changed

2 files changed

+16
-4
lines changed

packages/react-devtools-shared/src/__tests__/dehydratedValueSerializer.js

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,18 @@ export function test(maybeDehydratedValue) {
2727
);
2828
}
2929

30+
function serializeDehydratedValuePreview(preview) {
31+
const date = new Date(preview);
32+
const isDatePreview = !Number.isNaN(date.valueOf());
33+
if (isDatePreview) {
34+
// The preview is just `String(date)` which formats the date in the local timezone.
35+
// This results in a snapshot mismatch between tests run in e.g. GMT and ET
36+
// WARNING: This does not guard against dates created with the default timezone i.e. the local timezone e.g. new Date('05 October 2011 14:48').
37+
return date.toISOString();
38+
}
39+
return preview;
40+
}
41+
3042
// print() is part of Jest's serializer API
3143
export function print(dehydratedValue, serialize, indent) {
3244
const {meta} = require('react-devtools-shared/src/hydration');
@@ -36,11 +48,11 @@ export function print(dehydratedValue, serialize, indent) {
3648
'Dehydrated {\n' +
3749
paddingLeft +
3850
' "preview_short": ' +
39-
dehydratedValue[meta.preview_short] +
51+
serializeDehydratedValuePreview(dehydratedValue[meta.preview_short]) +
4052
',\n' +
4153
paddingLeft +
4254
' "preview_long": ' +
43-
dehydratedValue[meta.preview_long] +
55+
serializeDehydratedValuePreview(dehydratedValue[meta.preview_long]) +
4456
',\n' +
4557
paddingLeft +
4658
'}'

packages/react-devtools-shared/src/__tests__/legacy/inspectElement-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -240,8 +240,8 @@ describe('InspectedElementContext', () => {
240240
"preview_long": DataView(3),
241241
},
242242
"date": Dehydrated {
243-
"preview_short": Thu Jan 01 1970 01:00:00 GMT+0100 (Central European Standard Time),
244-
"preview_long": Thu Jan 01 1970 01:00:00 GMT+0100 (Central European Standard Time),
243+
"preview_short": 1970-01-01T00:00:00.000Z,
244+
"preview_long": 1970-01-01T00:00:00.000Z,
245245
},
246246
"fn": Dehydrated {
247247
"preview_short": ƒ exampleFunction() {},

0 commit comments

Comments
 (0)