Skip to content

Commit 9908c7d

Browse files
committed
Clean up enableSyncDefaultUpdates flag a bit (#26858)
## Overview Does a few things: - Renames `enableSyncDefaultUpdates` to `forceConcurrentByDefaultForTesting` - Changes the way it's used so it's dead-code eliminated separate from `allowConcurrentByDefault` - Deletes a bunch of the gated code The gates that are deleted are unnecessary now. We were keeping them when we originally thought we would come back to being concurrent by default. But we've shifted and now sync-by default is the desired behavior long term, so there's no need to keep all these forked tests around. I'll follow up to delete more of the forked behavior if possible. Ideally we wouldn't need this flag even if we're still using `allowConcurrentByDefault`. DiffTrain build for [018c58c](018c58c)
1 parent ea7881e commit 9908c7d

12 files changed

+16
-32
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
ae31d2ea3c3f9f0a87ff2c6193484d5d8786bc5f
1+
018c58c9c65452cff25aaf1f38f78a9b90d8e5c1

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-www-modern-335642a1";
30+
var ReactVersion = "18.3.0-www-modern-d087d75f";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
6969
return self;
7070
}
7171

72-
var ReactVersion = "18.3.0-www-classic-9ecb0062";
72+
var ReactVersion = "18.3.0-www-classic-603b8e54";
7373

7474
var LegacyRoot = 0;
7575
var ConcurrentRoot = 1;
@@ -28023,8 +28023,6 @@ function createHostRootFiber(
2802328023
}
2802428024

2802528025
if (
28026-
// We only use this flag for our repo tests to check both behaviors.
28027-
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
2802828026
// Only for internal experiments.
2802928027
concurrentUpdatesByDefaultOverride
2803028028
) {

compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
6969
return self;
7070
}
7171

72-
var ReactVersion = "18.3.0-www-modern-335642a1";
72+
var ReactVersion = "18.3.0-www-modern-d087d75f";
7373

7474
var LegacyRoot = 0;
7575
var ConcurrentRoot = 1;
@@ -27683,8 +27683,6 @@ function createHostRootFiber(
2768327683
}
2768427684

2768527685
if (
27686-
// We only use this flag for our repo tests to check both behaviors.
27687-
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
2768827686
// Only for internal experiments.
2768927687
concurrentUpdatesByDefaultOverride
2769027688
) {

compiled/facebook-www/ReactDOM-dev.classic.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33640,8 +33640,6 @@ function createHostRootFiber(
3364033640
}
3364133641

3364233642
if (
33643-
// We only use this flag for our repo tests to check both behaviors.
33644-
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
3364533643
// Only for internal experiments.
3364633644
concurrentUpdatesByDefaultOverride
3364733645
) {
@@ -34196,7 +34194,7 @@ function createFiberRoot(
3419634194
return root;
3419734195
}
3419834196

34199-
var ReactVersion = "18.3.0-www-classic-ea4ca273";
34197+
var ReactVersion = "18.3.0-www-classic-531a5c2f";
3420034198

3420134199
function createPortal$1(
3420234200
children,

compiled/facebook-www/ReactDOM-dev.modern.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33485,8 +33485,6 @@ function createHostRootFiber(
3348533485
}
3348633486

3348733487
if (
33488-
// We only use this flag for our repo tests to check both behaviors.
33489-
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
3349033488
// Only for internal experiments.
3349133489
concurrentUpdatesByDefaultOverride
3349233490
) {
@@ -34041,7 +34039,7 @@ function createFiberRoot(
3404134039
return root;
3404234040
}
3404334041

34044-
var ReactVersion = "18.3.0-www-modern-e59407a6";
34042+
var ReactVersion = "18.3.0-www-modern-7cf6b354";
3404534043

3404634044
function createPortal$1(
3404734045
children,

compiled/facebook-www/ReactDOM-prod.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16652,7 +16652,7 @@ Internals.Events = [
1665216652
var devToolsConfig$jscomp$inline_1827 = {
1665316653
findFiberByHostInstance: getClosestInstanceFromNode,
1665416654
bundleType: 0,
16655-
version: "18.3.0-www-classic-9ecb0062",
16655+
version: "18.3.0-www-classic-603b8e54",
1665616656
rendererPackageName: "react-dom"
1665716657
};
1665816658
var internals$jscomp$inline_2201 = {
@@ -16682,7 +16682,7 @@ var internals$jscomp$inline_2201 = {
1668216682
scheduleRoot: null,
1668316683
setRefreshHandler: null,
1668416684
getCurrentFiber: null,
16685-
reconcilerVersion: "18.3.0-www-classic-9ecb0062"
16685+
reconcilerVersion: "18.3.0-www-classic-603b8e54"
1668616686
};
1668716687
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1668816688
var hook$jscomp$inline_2202 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -16925,4 +16925,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
1692516925
);
1692616926
};
1692716927
exports.unstable_runWithPriority = runWithPriority;
16928-
exports.version = "18.3.0-www-classic-9ecb0062";
16928+
exports.version = "18.3.0-www-classic-603b8e54";

compiled/facebook-www/ReactDOMTesting-dev.classic.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34257,8 +34257,6 @@ function createHostRootFiber(
3425734257
}
3425834258

3425934259
if (
34260-
// We only use this flag for our repo tests to check both behaviors.
34261-
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
3426234260
// Only for internal experiments.
3426334261
concurrentUpdatesByDefaultOverride
3426434262
) {
@@ -34813,7 +34811,7 @@ function createFiberRoot(
3481334811
return root;
3481434812
}
3481534813

34816-
var ReactVersion = "18.3.0-www-classic-e7fd2804";
34814+
var ReactVersion = "18.3.0-www-classic-db5b17c5";
3481734815

3481834816
function createPortal$1(
3481934817
children,

compiled/facebook-www/ReactDOMTesting-dev.modern.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34102,8 +34102,6 @@ function createHostRootFiber(
3410234102
}
3410334103

3410434104
if (
34105-
// We only use this flag for our repo tests to check both behaviors.
34106-
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
3410734105
// Only for internal experiments.
3410834106
concurrentUpdatesByDefaultOverride
3410934107
) {
@@ -34658,7 +34656,7 @@ function createFiberRoot(
3465834656
return root;
3465934657
}
3466034658

34661-
var ReactVersion = "18.3.0-www-modern-380d0892";
34659+
var ReactVersion = "18.3.0-www-modern-427e8396";
3466234660

3466334661
function createPortal$1(
3466434662
children,

compiled/facebook-www/ReactDOMTesting-prod.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16563,7 +16563,7 @@ Internals.Events = [
1656316563
var devToolsConfig$jscomp$inline_1815 = {
1656416564
findFiberByHostInstance: getClosestInstanceFromNode,
1656516565
bundleType: 0,
16566-
version: "18.3.0-www-modern-335642a1",
16566+
version: "18.3.0-www-modern-d087d75f",
1656716567
rendererPackageName: "react-dom"
1656816568
};
1656916569
var internals$jscomp$inline_2199 = {
@@ -16594,7 +16594,7 @@ var internals$jscomp$inline_2199 = {
1659416594
scheduleRoot: null,
1659516595
setRefreshHandler: null,
1659616596
getCurrentFiber: null,
16597-
reconcilerVersion: "18.3.0-www-modern-335642a1"
16597+
reconcilerVersion: "18.3.0-www-modern-d087d75f"
1659816598
};
1659916599
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1660016600
var hook$jscomp$inline_2200 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -16916,4 +16916,4 @@ exports.unstable_createEventHandle = function (type, options) {
1691616916
return eventHandle;
1691716917
};
1691816918
exports.unstable_runWithPriority = runWithPriority;
16919-
exports.version = "18.3.0-www-modern-335642a1";
16919+
exports.version = "18.3.0-www-modern-d087d75f";

0 commit comments

Comments
 (0)