Skip to content

Commit 6db4aa0

Browse files
sebmarkbagesebmarkbage
committed
[Flight] Emit Partial Debug Info if we have any at the point of aborting a render (#33632)
When we abort a render we don't really have much information about the task that was aborted. Because before a Promise resolves there's no indication about would have resolved it. In particular we don't know which I/O would've ultimately called resolve(). However, we can at least emit any information we do have at the point where we emit it. At the least the stack of the top most Promise. Currently we synchronously flush at the end of an `abort()` but we should ideally schedule the flush in a macrotask and emit this debug information right before that. That way we would give an opportunity for any `cacheSignal()` abort to trigger rejections all the way up and those rejections informs the awaited stack. --------- Co-authored-by: Hendrik Liebau <[email protected]> DiffTrain build for [e67b4fe](e67b4fe)
1 parent 99aa3a2 commit 6db4aa0

24 files changed

+721
-651
lines changed

‎compiled-rn/VERSION_NATIVE_FB

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.2.0-native-fb-94cf60be-20250624
1+
19.2.0-native-fb-e67b4fe2-20250624

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<1fbaa44f01b315519e37589b4ec6e754>>
10+
* @generated SignedSource<<fa098fba5d8d945a13d13b2e957df11e>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.2.0-native-fb-94cf60be-20250624";
407+
exports.version = "19.2.0-native-fb-e67b4fe2-20250624";
408408
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<cb7bb6425db315fd2f0f12ad7472bb4d>>
10+
* @generated SignedSource<<751a26b4f7a58b2a156281f634c3fc3b>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-94cf60be-20250624";
206+
exports.version = "19.2.0-native-fb-e67b4fe2-20250624";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<cb7bb6425db315fd2f0f12ad7472bb4d>>
10+
* @generated SignedSource<<751a26b4f7a58b2a156281f634c3fc3b>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-94cf60be-20250624";
206+
exports.version = "19.2.0-native-fb-e67b4fe2-20250624";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js

Lines changed: 159 additions & 145 deletions
Large diffs are not rendered by default.

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<e2d402f3e2921d46ec64aa02cae8a6c5>>
10+
* @generated SignedSource<<84e82f6218189a363fac2c7b40fc5145>>
1111
*/
1212

1313
/*
@@ -12992,20 +12992,20 @@ function debounceScrollEnd(targetInst, nativeEvent, nativeEventTarget) {
1299212992
(nativeEventTarget[internalScrollTimer] = targetInst));
1299312993
}
1299412994
for (
12995-
var i$jscomp$inline_1641 = 0;
12996-
i$jscomp$inline_1641 < simpleEventPluginEvents.length;
12997-
i$jscomp$inline_1641++
12995+
var i$jscomp$inline_1647 = 0;
12996+
i$jscomp$inline_1647 < simpleEventPluginEvents.length;
12997+
i$jscomp$inline_1647++
1299812998
) {
12999-
var eventName$jscomp$inline_1642 =
13000-
simpleEventPluginEvents[i$jscomp$inline_1641],
13001-
domEventName$jscomp$inline_1643 =
13002-
eventName$jscomp$inline_1642.toLowerCase(),
13003-
capitalizedEvent$jscomp$inline_1644 =
13004-
eventName$jscomp$inline_1642[0].toUpperCase() +
13005-
eventName$jscomp$inline_1642.slice(1);
12999+
var eventName$jscomp$inline_1648 =
13000+
simpleEventPluginEvents[i$jscomp$inline_1647],
13001+
domEventName$jscomp$inline_1649 =
13002+
eventName$jscomp$inline_1648.toLowerCase(),
13003+
capitalizedEvent$jscomp$inline_1650 =
13004+
eventName$jscomp$inline_1648[0].toUpperCase() +
13005+
eventName$jscomp$inline_1648.slice(1);
1300613006
registerSimpleEvent(
13007-
domEventName$jscomp$inline_1643,
13008-
"on" + capitalizedEvent$jscomp$inline_1644
13007+
domEventName$jscomp$inline_1649,
13008+
"on" + capitalizedEvent$jscomp$inline_1650
1300913009
);
1301013010
}
1301113011
registerSimpleEvent(ANIMATION_END, "onAnimationEnd");
@@ -17119,16 +17119,16 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1711917119
0 === i && attemptExplicitHydrationTarget(target);
1712017120
}
1712117121
};
17122-
var isomorphicReactPackageVersion$jscomp$inline_2017 = React.version;
17122+
var isomorphicReactPackageVersion$jscomp$inline_2023 = React.version;
1712317123
if (
17124-
"19.2.0-native-fb-94cf60be-20250624" !==
17125-
isomorphicReactPackageVersion$jscomp$inline_2017
17124+
"19.2.0-native-fb-e67b4fe2-20250624" !==
17125+
isomorphicReactPackageVersion$jscomp$inline_2023
1712617126
)
1712717127
throw Error(
1712817128
formatProdErrorMessage(
1712917129
527,
17130-
isomorphicReactPackageVersion$jscomp$inline_2017,
17131-
"19.2.0-native-fb-94cf60be-20250624"
17130+
isomorphicReactPackageVersion$jscomp$inline_2023,
17131+
"19.2.0-native-fb-e67b4fe2-20250624"
1713217132
)
1713317133
);
1713417134
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17148,24 +17148,24 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1714817148
null === componentOrElement ? null : componentOrElement.stateNode;
1714917149
return componentOrElement;
1715017150
};
17151-
var internals$jscomp$inline_2536 = {
17151+
var internals$jscomp$inline_2542 = {
1715217152
bundleType: 0,
17153-
version: "19.2.0-native-fb-94cf60be-20250624",
17153+
version: "19.2.0-native-fb-e67b4fe2-20250624",
1715417154
rendererPackageName: "react-dom",
1715517155
currentDispatcherRef: ReactSharedInternals,
17156-
reconcilerVersion: "19.2.0-native-fb-94cf60be-20250624"
17156+
reconcilerVersion: "19.2.0-native-fb-e67b4fe2-20250624"
1715717157
};
1715817158
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
17159-
var hook$jscomp$inline_2537 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
17159+
var hook$jscomp$inline_2543 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
1716017160
if (
17161-
!hook$jscomp$inline_2537.isDisabled &&
17162-
hook$jscomp$inline_2537.supportsFiber
17161+
!hook$jscomp$inline_2543.isDisabled &&
17162+
hook$jscomp$inline_2543.supportsFiber
1716317163
)
1716417164
try {
17165-
(rendererID = hook$jscomp$inline_2537.inject(
17166-
internals$jscomp$inline_2536
17165+
(rendererID = hook$jscomp$inline_2543.inject(
17166+
internals$jscomp$inline_2542
1716717167
)),
17168-
(injectedHook = hook$jscomp$inline_2537);
17168+
(injectedHook = hook$jscomp$inline_2543);
1716917169
} catch (err) {}
1717017170
}
1717117171
exports.createRoot = function (container, options) {
@@ -17251,4 +17251,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1725117251
listenToAllSupportedEvents(container);
1725217252
return new ReactDOMHydrationRoot(initialChildren);
1725317253
};
17254-
exports.version = "19.2.0-native-fb-94cf60be-20250624";
17254+
exports.version = "19.2.0-native-fb-e67b4fe2-20250624";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9e66c60850af155654031ea08828bfb9>>
10+
* @generated SignedSource<<ae9ac5dd6ecd7b6811e9009356bbef31>>
1111
*/
1212

1313
/*
@@ -14906,20 +14906,20 @@ function debounceScrollEnd(targetInst, nativeEvent, nativeEventTarget) {
1490614906
(nativeEventTarget[internalScrollTimer] = targetInst));
1490714907
}
1490814908
for (
14909-
var i$jscomp$inline_1877 = 0;
14910-
i$jscomp$inline_1877 < simpleEventPluginEvents.length;
14911-
i$jscomp$inline_1877++
14909+
var i$jscomp$inline_1883 = 0;
14910+
i$jscomp$inline_1883 < simpleEventPluginEvents.length;
14911+
i$jscomp$inline_1883++
1491214912
) {
14913-
var eventName$jscomp$inline_1878 =
14914-
simpleEventPluginEvents[i$jscomp$inline_1877],
14915-
domEventName$jscomp$inline_1879 =
14916-
eventName$jscomp$inline_1878.toLowerCase(),
14917-
capitalizedEvent$jscomp$inline_1880 =
14918-
eventName$jscomp$inline_1878[0].toUpperCase() +
14919-
eventName$jscomp$inline_1878.slice(1);
14913+
var eventName$jscomp$inline_1884 =
14914+
simpleEventPluginEvents[i$jscomp$inline_1883],
14915+
domEventName$jscomp$inline_1885 =
14916+
eventName$jscomp$inline_1884.toLowerCase(),
14917+
capitalizedEvent$jscomp$inline_1886 =
14918+
eventName$jscomp$inline_1884[0].toUpperCase() +
14919+
eventName$jscomp$inline_1884.slice(1);
1492014920
registerSimpleEvent(
14921-
domEventName$jscomp$inline_1879,
14922-
"on" + capitalizedEvent$jscomp$inline_1880
14921+
domEventName$jscomp$inline_1885,
14922+
"on" + capitalizedEvent$jscomp$inline_1886
1492314923
);
1492414924
}
1492514925
registerSimpleEvent(ANIMATION_END, "onAnimationEnd");
@@ -19051,16 +19051,16 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1905119051
0 === i && attemptExplicitHydrationTarget(target);
1905219052
}
1905319053
};
19054-
var isomorphicReactPackageVersion$jscomp$inline_2255 = React.version;
19054+
var isomorphicReactPackageVersion$jscomp$inline_2261 = React.version;
1905519055
if (
19056-
"19.2.0-native-fb-94cf60be-20250624" !==
19057-
isomorphicReactPackageVersion$jscomp$inline_2255
19056+
"19.2.0-native-fb-e67b4fe2-20250624" !==
19057+
isomorphicReactPackageVersion$jscomp$inline_2261
1905819058
)
1905919059
throw Error(
1906019060
formatProdErrorMessage(
1906119061
527,
19062-
isomorphicReactPackageVersion$jscomp$inline_2255,
19063-
"19.2.0-native-fb-94cf60be-20250624"
19062+
isomorphicReactPackageVersion$jscomp$inline_2261,
19063+
"19.2.0-native-fb-e67b4fe2-20250624"
1906419064
)
1906519065
);
1906619066
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19080,12 +19080,12 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1908019080
null === componentOrElement ? null : componentOrElement.stateNode;
1908119081
return componentOrElement;
1908219082
};
19083-
var internals$jscomp$inline_2262 = {
19083+
var internals$jscomp$inline_2268 = {
1908419084
bundleType: 0,
19085-
version: "19.2.0-native-fb-94cf60be-20250624",
19085+
version: "19.2.0-native-fb-e67b4fe2-20250624",
1908619086
rendererPackageName: "react-dom",
1908719087
currentDispatcherRef: ReactSharedInternals,
19088-
reconcilerVersion: "19.2.0-native-fb-94cf60be-20250624",
19088+
reconcilerVersion: "19.2.0-native-fb-e67b4fe2-20250624",
1908919089
getLaneLabelMap: function () {
1909019090
for (
1909119091
var map = new Map(), lane = 1, index$331 = 0;
@@ -19103,16 +19103,16 @@ var internals$jscomp$inline_2262 = {
1910319103
}
1910419104
};
1910519105
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
19106-
var hook$jscomp$inline_2775 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
19106+
var hook$jscomp$inline_2781 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
1910719107
if (
19108-
!hook$jscomp$inline_2775.isDisabled &&
19109-
hook$jscomp$inline_2775.supportsFiber
19108+
!hook$jscomp$inline_2781.isDisabled &&
19109+
hook$jscomp$inline_2781.supportsFiber
1911019110
)
1911119111
try {
19112-
(rendererID = hook$jscomp$inline_2775.inject(
19113-
internals$jscomp$inline_2262
19112+
(rendererID = hook$jscomp$inline_2781.inject(
19113+
internals$jscomp$inline_2268
1911419114
)),
19115-
(injectedHook = hook$jscomp$inline_2775);
19115+
(injectedHook = hook$jscomp$inline_2781);
1911619116
} catch (err) {}
1911719117
}
1911819118
exports.createRoot = function (container, options) {
@@ -19198,4 +19198,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1919819198
listenToAllSupportedEvents(container);
1919919199
return new ReactDOMHydrationRoot(initialChildren);
1920019200
};
19201-
exports.version = "19.2.0-native-fb-94cf60be-20250624";
19201+
exports.version = "19.2.0-native-fb-e67b4fe2-20250624";

0 commit comments

Comments
 (0)