[flow] Upgrade Flow to 0.245.2

Author: SamChou19815

package.json

@@ -63,8 +63,8 @@
     "eslint-plugin-react-internal": "link:./scripts/eslint-rules",
     "fbjs-scripts": "^3.0.1",
     "filesize": "^6.0.1",
-    "flow-bin": "^0.235.0",
-    "flow-remove-types": "^2.235.0",
+    "flow-bin": "^0.245.2",
+    "flow-remove-types": "^2.245.2",
     "glob": "^7.1.6",
     "glob-stream": "^6.1.0",
     "google-closure-compiler": "^20230206.0.0",

packages/internal-test-utils/internalAct.js

@@ -163,6 +163,7 @@ export async function act<T>(scope: () => Thenable<T>): Thenable<T> {
       throw thrownError;
     }
 
+    // $FlowFixMe[incompatible-return]
     return result;
   } finally {
     const depth = actingUpdatesScopeDepth;
@@ -271,6 +272,7 @@ export async function serverAct<T>(scope: () => Thenable<T>): Thenable<T> {
       throw thrownError;
     }
 
+    // $FlowFixMe[incompatible-return]
     return result;
   } finally {
     if (typeof process === 'object') {

packages/react-client/src/ReactFlightReplyClient.js

@@ -554,6 +554,7 @@ export function processReply(
         const prefix = formFieldPrefix + refId + '_';
         // $FlowFixMe[prop-missing]: FormData has forEach.
         value.forEach((originalValue: string | File, originalKey: string) => {
+          // $FlowFixMe[incompatible-call]
           data.append(prefix + originalKey, originalValue);
         });
         return serializeFormDataReference(refId);
@@ -925,6 +926,7 @@ function defaultEncodeFormAction(
     const prefixedData = new FormData();
     // $FlowFixMe[prop-missing]
     encodedFormData.forEach((value: string | File, key: string) => {
+      // $FlowFixMe[incompatible-call]
       prefixedData.append('$ACTION_' + identifierPrefix + ':' + key, value);
     });
     data = prefixedData;
@@ -1153,6 +1155,7 @@ const FunctionBind = Function.prototype.bind;
 const ArraySlice = Array.prototype.slice;
 function bind(this: Function): Function {
   // $FlowFixMe[unsupported-syntax]
+  // $FlowFixMe[prop-missing]
   const newFn = FunctionBind.apply(this, arguments);
   const reference = knownServerReferences.get(this);
   if (reference) {

packages/react-debug-tools/src/ReactDebugHooks.js

@@ -1033,6 +1033,7 @@ function buildTree(
         }
         // Pop back the stack as many steps as were not common.
         for (let j = prevStack.length - 1; j > commonSteps; j--) {
+          // $FlowFixMe[incompatible-type]
           levelChildren = stackOfChildren.pop();
         }
       }

packages/react-devtools-shared/src/backend/profilingHooks.js

@@ -274,16 +274,19 @@ export function createProfilingHooks({
     }
 
     const top = currentReactMeasuresStack.pop();
+    // $FlowFixMe[incompatible-type]
     if (top.type !== type) {
       console.error(
         'Unexpected type "%s" completed at %sms before "%s" completed.',
         type,
         currentTime,
+        // $FlowFixMe[incompatible-use]
         top.type,
       );
     }
 
     // $FlowFixMe[cannot-write] This property should not be writable outside of this function.
+    // $FlowFixMe[incompatible-use]
     top.duration = currentTime - top.timestamp;
 
     if (currentTimelineData) {

packages/react-devtools-shared/src/backend/utils.js

@@ -299,10 +299,12 @@ export function formatConsoleArgumentsToSingleString(
     if (args.length) {
       const REGEXP = /(%?)(%([jds]))/g;
 
+      // $FlowFixMe[incompatible-call]
       formatted = formatted.replace(REGEXP, (match, escaped, ptn, flag) => {
         let arg = args.shift();
         switch (flag) {
           case 's':
+            // $FlowFixMe[unsafe-addition]
             arg += '';
             break;
           case 'd':

packages/react-devtools-shared/src/backend/views/Highlighter/Overlay.js

@@ -194,6 +194,7 @@ export default class Overlay {
 
     while (this.rects.length > elements.length) {
       const rect = this.rects.pop();
+      // $FlowFixMe[incompatible-use]
       rect.remove();
     }
     if (elements.length === 0) {

packages/react-devtools-shared/src/devtools/views/Profiler/CommitTreeBuilder.js

@@ -391,18 +391,22 @@ const __printTree = (commitTree: CommitTree) => {
       const id = queue.shift();
       const depth = queue.shift();
 
+      // $FlowFixMe[incompatible-call]
       const node = nodes.get(id);
       if (node == null) {
+        // $FlowFixMe[incompatible-type]
         throw Error(`Could not find node with id "${id}" in commit tree`);
       }
 
       console.log(
+        // $FlowFixMe[incompatible-call]
         `${'•'.repeat(depth)}${node.id}:${node.displayName || ''} ${
           node.key ? `key:"${node.key}"` : ''
         } (${node.treeBaseDuration})`,
       );
 
       node.children.forEach(childID => {
+        // $FlowFixMe[unsafe-addition]
         queue.push(childID, depth + 1);
       });
     }

packages/react-devtools-shared/src/devtools/views/utils.js

@@ -142,10 +142,14 @@ export function serializeHooksForCopy(hooks: HooksTree | null): string {
     const current = queue.pop();
 
     // These aren't meaningful
+    // $FlowFixMe[incompatible-use]
     delete current.id;
+    // $FlowFixMe[incompatible-use]
     delete current.isStateEditable;
 
+    // $FlowFixMe[incompatible-use]
     if (current.subHooks.length > 0) {
+      // $FlowFixMe[incompatible-use]
       queue.push(...current.subHooks);
     }
   }

packages/react-devtools-shared/src/hook.js

@@ -532,6 +532,7 @@ export function installHook(target: any): DevToolsHook | null {
       const startStackFrame = openModuleRangesStack.pop();
       const stopStackFrame = getTopStackFrameString(error);
       if (stopStackFrame !== null) {
+        // $FlowFixMe[incompatible-call]
         moduleRanges.push([startStackFrame, stopStackFrame]);
       }
     }