Skip to content

Commit 3d6033a

Browse files
committed
New children notify fragment instances in Fabric (#33093)
When a new child of a fragment instance is inserted, we need to notify the instance to keep any relevant tracking up to date. For example, we automatically observe the new child with any active IntersectionObserver. For mutable renderers (DOM), we reuse the existing traversal in `commitPlacement` that does the insertions for HostComponents. Immutable renderers (Fabric) exit this path before the traversal though, so currently we can't notify the fragment instances. Here I've created a separate traversal in `commitPlacement`, specifically for immutable renders when `enableFragmentRefs` is on. DiffTrain build for [1835b3f](1835b3f)
1 parent 3992609 commit 3d6033a

34 files changed

+650
-556
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
f4041aa388b7eeba94a26f6c273e9f4c18e2d2b3
1+
1835b3f7d9c0541259a8812c5dfaf3d77f0721eb
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
f4041aa388b7eeba94a26f6c273e9f4c18e2d2b3
1+
1835b3f7d9c0541259a8812c5dfaf3d77f0721eb

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1537,7 +1537,7 @@ __DEV__ &&
15371537
exports.useTransition = function () {
15381538
return resolveDispatcher().useTransition();
15391539
};
1540-
exports.version = "19.2.0-www-classic-f4041aa3-20250521";
1540+
exports.version = "19.2.0-www-classic-1835b3f7-20250521";
15411541
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15421542
"function" ===
15431543
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1537,7 +1537,7 @@ __DEV__ &&
15371537
exports.useTransition = function () {
15381538
return resolveDispatcher().useTransition();
15391539
};
1540-
exports.version = "19.2.0-www-modern-f4041aa3-20250521";
1540+
exports.version = "19.2.0-www-modern-1835b3f7-20250521";
15411541
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15421542
"function" ===
15431543
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -635,4 +635,4 @@ exports.useSyncExternalStore = function (
635635
exports.useTransition = function () {
636636
return ReactSharedInternals.H.useTransition();
637637
};
638-
exports.version = "19.2.0-www-classic-f4041aa3-20250521";
638+
exports.version = "19.2.0-www-classic-1835b3f7-20250521";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -635,4 +635,4 @@ exports.useSyncExternalStore = function (
635635
exports.useTransition = function () {
636636
return ReactSharedInternals.H.useTransition();
637637
};
638-
exports.version = "19.2.0-www-modern-f4041aa3-20250521";
638+
exports.version = "19.2.0-www-modern-1835b3f7-20250521";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,7 +639,7 @@ exports.useSyncExternalStore = function (
639639
exports.useTransition = function () {
640640
return ReactSharedInternals.H.useTransition();
641641
};
642-
exports.version = "19.2.0-www-classic-f4041aa3-20250521";
642+
exports.version = "19.2.0-www-classic-1835b3f7-20250521";
643643
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
644644
"function" ===
645645
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,7 +639,7 @@ exports.useSyncExternalStore = function (
639639
exports.useTransition = function () {
640640
return ReactSharedInternals.H.useTransition();
641641
};
642-
exports.version = "19.2.0-www-modern-f4041aa3-20250521";
642+
exports.version = "19.2.0-www-modern-1835b3f7-20250521";
643643
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
644644
"function" ===
645645
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19080,10 +19080,10 @@ __DEV__ &&
1908019080
(function () {
1908119081
var internals = {
1908219082
bundleType: 1,
19083-
version: "19.2.0-www-classic-f4041aa3-20250521",
19083+
version: "19.2.0-www-classic-1835b3f7-20250521",
1908419084
rendererPackageName: "react-art",
1908519085
currentDispatcherRef: ReactSharedInternals,
19086-
reconcilerVersion: "19.2.0-www-classic-f4041aa3-20250521"
19086+
reconcilerVersion: "19.2.0-www-classic-1835b3f7-20250521"
1908719087
};
1908819088
internals.overrideHookState = overrideHookState;
1908919089
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -19117,7 +19117,7 @@ __DEV__ &&
1911719117
exports.Shape = Shape;
1911819118
exports.Surface = Surface;
1911919119
exports.Text = Text;
19120-
exports.version = "19.2.0-www-classic-f4041aa3-20250521";
19120+
exports.version = "19.2.0-www-classic-1835b3f7-20250521";
1912119121
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1912219122
"function" ===
1912319123
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18852,10 +18852,10 @@ __DEV__ &&
1885218852
(function () {
1885318853
var internals = {
1885418854
bundleType: 1,
18855-
version: "19.2.0-www-modern-f4041aa3-20250521",
18855+
version: "19.2.0-www-modern-1835b3f7-20250521",
1885618856
rendererPackageName: "react-art",
1885718857
currentDispatcherRef: ReactSharedInternals,
18858-
reconcilerVersion: "19.2.0-www-modern-f4041aa3-20250521"
18858+
reconcilerVersion: "19.2.0-www-modern-1835b3f7-20250521"
1885918859
};
1886018860
internals.overrideHookState = overrideHookState;
1886118861
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -18889,7 +18889,7 @@ __DEV__ &&
1888918889
exports.Shape = Shape;
1889018890
exports.Surface = Surface;
1889118891
exports.Text = Text;
18892-
exports.version = "19.2.0-www-modern-f4041aa3-20250521";
18892+
exports.version = "19.2.0-www-modern-1835b3f7-20250521";
1889318893
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1889418894
"function" ===
1889518895
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)