Skip to content

Commit 32628e2

Browse files
hoxyqhoxyq
committed
fix: rename bottom stack frame (#33680)
`react-stack-bottom-frame` -> `react_stack_bottom_frame`. This survives `@babel/plugin-transform-function-name`, but now frames will be displayed as `at Object.react_stack_bottom_frame (...)` in V8. Checks that were relying on exact function name match were updated to use either `.indexOf()` or `.includes()` For backwards compatibility, both React DevTools and Flight Client will look for both options. I am not so sure about the latter and if React version is locked. DiffTrain build for [91d097b](91d097b)
1 parent 59b630f commit 32628e2

26 files changed

+250
-235
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.2.0-native-fb-1e0d12b6-20250630
1+
19.2.0-native-fb-91d097b2-20250701

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<6151a3ea5c457e516c23b3510cab37c9>>
10+
* @generated SignedSource<<a5249ec7acefa6006896559c407dc270>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.2.0-native-fb-1e0d12b6-20250630";
407+
exports.version = "19.2.0-native-fb-91d097b2-20250701";
408408
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<5ea400663d78461b7ae19cdb14993c0a>>
10+
* @generated SignedSource<<a578d90cf5683ea23322c8c54361e660>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-1e0d12b6-20250630";
206+
exports.version = "19.2.0-native-fb-91d097b2-20250701";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<5ea400663d78461b7ae19cdb14993c0a>>
10+
* @generated SignedSource<<a578d90cf5683ea23322c8c54361e660>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-1e0d12b6-20250630";
206+
exports.version = "19.2.0-native-fb-91d097b2-20250701";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js‎

Lines changed: 37 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<00d94ed557e361ae73a8497c7f56314d>>
10+
* @generated SignedSource<<3ed4f46c5b177e202e0babc67d3b7d65>>
1111
*/
1212

1313
/*
@@ -643,7 +643,7 @@ __DEV__ &&
643643
prevPrepareStackTrace = error.indexOf("\n");
644644
-1 !== prevPrepareStackTrace &&
645645
(error = error.slice(prevPrepareStackTrace + 1));
646-
prevPrepareStackTrace = error.indexOf("react-stack-bottom-frame");
646+
prevPrepareStackTrace = error.indexOf("react_stack_bottom_frame");
647647
-1 !== prevPrepareStackTrace &&
648648
(prevPrepareStackTrace = error.lastIndexOf(
649649
"\n",
@@ -26637,7 +26637,7 @@ __DEV__ &&
2663726637
suspendedThenable = null,
2663826638
needsToResetSuspendedThenableDEV = !1,
2663926639
callComponent = {
26640-
"react-stack-bottom-frame": function (Component, props, secondArg) {
26640+
react_stack_bottom_frame: function (Component, props, secondArg) {
2664126641
var wasRendering = isRendering;
2664226642
isRendering = !0;
2664326643
try {
@@ -26648,9 +26648,9 @@ __DEV__ &&
2664826648
}
2664926649
},
2665026650
callComponentInDEV =
26651-
callComponent["react-stack-bottom-frame"].bind(callComponent),
26651+
callComponent.react_stack_bottom_frame.bind(callComponent),
2665226652
callRender = {
26653-
"react-stack-bottom-frame": function (instance) {
26653+
react_stack_bottom_frame: function (instance) {
2665426654
var wasRendering = isRendering;
2665526655
isRendering = !0;
2665626656
try {
@@ -26660,21 +26660,22 @@ __DEV__ &&
2666026660
}
2666126661
}
2666226662
},
26663-
callRenderInDEV = callRender["react-stack-bottom-frame"].bind(callRender),
26663+
callRenderInDEV = callRender.react_stack_bottom_frame.bind(callRender),
2666426664
callComponentDidMount = {
26665-
"react-stack-bottom-frame": function (finishedWork, instance) {
26665+
react_stack_bottom_frame: function (finishedWork, instance) {
2666626666
try {
2666726667
instance.componentDidMount();
2666826668
} catch (error) {
2666926669
captureCommitPhaseError(finishedWork, finishedWork.return, error);
2667026670
}
2667126671
}
2667226672
},
26673-
callComponentDidMountInDEV = callComponentDidMount[
26674-
"react-stack-bottom-frame"
26675-
].bind(callComponentDidMount),
26673+
callComponentDidMountInDEV =
26674+
callComponentDidMount.react_stack_bottom_frame.bind(
26675+
callComponentDidMount
26676+
),
2667626677
callComponentDidUpdate = {
26677-
"react-stack-bottom-frame": function (
26678+
react_stack_bottom_frame: function (
2667826679
finishedWork,
2667926680
instance,
2668026681
prevProps,
@@ -26688,22 +26689,24 @@ __DEV__ &&
2668826689
}
2668926690
}
2669026691
},
26691-
callComponentDidUpdateInDEV = callComponentDidUpdate[
26692-
"react-stack-bottom-frame"
26693-
].bind(callComponentDidUpdate),
26692+
callComponentDidUpdateInDEV =
26693+
callComponentDidUpdate.react_stack_bottom_frame.bind(
26694+
callComponentDidUpdate
26695+
),
2669426696
callComponentDidCatch = {
26695-
"react-stack-bottom-frame": function (instance, errorInfo) {
26697+
react_stack_bottom_frame: function (instance, errorInfo) {
2669626698
var stack = errorInfo.stack;
2669726699
instance.componentDidCatch(errorInfo.value, {
2669826700
componentStack: null !== stack ? stack : ""
2669926701
});
2670026702
}
2670126703
},
26702-
callComponentDidCatchInDEV = callComponentDidCatch[
26703-
"react-stack-bottom-frame"
26704-
].bind(callComponentDidCatch),
26704+
callComponentDidCatchInDEV =
26705+
callComponentDidCatch.react_stack_bottom_frame.bind(
26706+
callComponentDidCatch
26707+
),
2670526708
callComponentWillUnmount = {
26706-
"react-stack-bottom-frame": function (
26709+
react_stack_bottom_frame: function (
2670726710
current,
2670826711
nearestMountedAncestor,
2670926712
instance
@@ -26715,20 +26718,21 @@ __DEV__ &&
2671526718
}
2671626719
}
2671726720
},
26718-
callComponentWillUnmountInDEV = callComponentWillUnmount[
26719-
"react-stack-bottom-frame"
26720-
].bind(callComponentWillUnmount),
26721+
callComponentWillUnmountInDEV =
26722+
callComponentWillUnmount.react_stack_bottom_frame.bind(
26723+
callComponentWillUnmount
26724+
),
2672126725
callCreate = {
26722-
"react-stack-bottom-frame": function (effect) {
26726+
react_stack_bottom_frame: function (effect) {
2672326727
var create = effect.create;
2672426728
effect = effect.inst;
2672526729
create = create();
2672626730
return (effect.destroy = create);
2672726731
}
2672826732
},
26729-
callCreateInDEV = callCreate["react-stack-bottom-frame"].bind(callCreate),
26733+
callCreateInDEV = callCreate.react_stack_bottom_frame.bind(callCreate),
2673026734
callDestroy = {
26731-
"react-stack-bottom-frame": function (
26735+
react_stack_bottom_frame: function (
2673226736
current,
2673326737
nearestMountedAncestor,
2673426738
destroy
@@ -26740,16 +26744,15 @@ __DEV__ &&
2674026744
}
2674126745
}
2674226746
},
26743-
callDestroyInDEV =
26744-
callDestroy["react-stack-bottom-frame"].bind(callDestroy),
26747+
callDestroyInDEV = callDestroy.react_stack_bottom_frame.bind(callDestroy),
2674526748
callLazyInit = {
26746-
"react-stack-bottom-frame": function (lazy) {
26749+
react_stack_bottom_frame: function (lazy) {
2674726750
var init = lazy._init;
2674826751
return init(lazy._payload);
2674926752
}
2675026753
},
2675126754
callLazyInitInDEV =
26752-
callLazyInit["react-stack-bottom-frame"].bind(callLazyInit),
26755+
callLazyInit.react_stack_bottom_frame.bind(callLazyInit),
2675326756
thenableState$1 = null,
2675426757
thenableIndexCounter$1 = 0,
2675526758
currentDebugInfo = null,
@@ -28844,11 +28847,11 @@ __DEV__ &&
2884428847
};
2884528848
(function () {
2884628849
var isomorphicReactPackageVersion = React.version;
28847-
if ("19.2.0-native-fb-1e0d12b6-20250630" !== isomorphicReactPackageVersion)
28850+
if ("19.2.0-native-fb-91d097b2-20250701" !== isomorphicReactPackageVersion)
2884828851
throw Error(
2884928852
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2885028853
(isomorphicReactPackageVersion +
28851-
"\n - react-dom: 19.2.0-native-fb-1e0d12b6-20250630\nLearn more: https://react.dev/warnings/version-mismatch")
28854+
"\n - react-dom: 19.2.0-native-fb-91d097b2-20250701\nLearn more: https://react.dev/warnings/version-mismatch")
2885228855
);
2885328856
})();
2885428857
("function" === typeof Map &&
@@ -28885,10 +28888,10 @@ __DEV__ &&
2888528888
!(function () {
2888628889
var internals = {
2888728890
bundleType: 1,
28888-
version: "19.2.0-native-fb-1e0d12b6-20250630",
28891+
version: "19.2.0-native-fb-91d097b2-20250701",
2888928892
rendererPackageName: "react-dom",
2889028893
currentDispatcherRef: ReactSharedInternals,
28891-
reconcilerVersion: "19.2.0-native-fb-1e0d12b6-20250630"
28894+
reconcilerVersion: "19.2.0-native-fb-91d097b2-20250701"
2889228895
};
2889328896
internals.overrideHookState = overrideHookState;
2889428897
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -29026,5 +29029,5 @@ __DEV__ &&
2902629029
listenToAllSupportedEvents(container);
2902729030
return new ReactDOMHydrationRoot(initialChildren);
2902829031
};
29029-
exports.version = "19.2.0-native-fb-1e0d12b6-20250630";
29032+
exports.version = "19.2.0-native-fb-91d097b2-20250701";
2903029033
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<5d3a93296313bf39079353b5d955af8a>>
10+
* @generated SignedSource<<5aa1e96b674062b509fb3a766589df97>>
1111
*/
1212

1313
/*
@@ -17121,14 +17121,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1712117121
};
1712217122
var isomorphicReactPackageVersion$jscomp$inline_2023 = React.version;
1712317123
if (
17124-
"19.2.0-native-fb-1e0d12b6-20250630" !==
17124+
"19.2.0-native-fb-91d097b2-20250701" !==
1712517125
isomorphicReactPackageVersion$jscomp$inline_2023
1712617126
)
1712717127
throw Error(
1712817128
formatProdErrorMessage(
1712917129
527,
1713017130
isomorphicReactPackageVersion$jscomp$inline_2023,
17131-
"19.2.0-native-fb-1e0d12b6-20250630"
17131+
"19.2.0-native-fb-91d097b2-20250701"
1713217132
)
1713317133
);
1713417134
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17150,10 +17150,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1715017150
};
1715117151
var internals$jscomp$inline_2542 = {
1715217152
bundleType: 0,
17153-
version: "19.2.0-native-fb-1e0d12b6-20250630",
17153+
version: "19.2.0-native-fb-91d097b2-20250701",
1715417154
rendererPackageName: "react-dom",
1715517155
currentDispatcherRef: ReactSharedInternals,
17156-
reconcilerVersion: "19.2.0-native-fb-1e0d12b6-20250630"
17156+
reconcilerVersion: "19.2.0-native-fb-91d097b2-20250701"
1715717157
};
1715817158
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1715917159
var hook$jscomp$inline_2543 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17251,4 +17251,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1725117251
listenToAllSupportedEvents(container);
1725217252
return new ReactDOMHydrationRoot(initialChildren);
1725317253
};
17254-
exports.version = "19.2.0-native-fb-1e0d12b6-20250630";
17254+
exports.version = "19.2.0-native-fb-91d097b2-20250701";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<af99db0b1378a83e657dfa8cb2505a2e>>
10+
* @generated SignedSource<<d644eef84b06788cf143ecbdd482f09d>>
1111
*/
1212

1313
/*
@@ -19053,14 +19053,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1905319053
};
1905419054
var isomorphicReactPackageVersion$jscomp$inline_2261 = React.version;
1905519055
if (
19056-
"19.2.0-native-fb-1e0d12b6-20250630" !==
19056+
"19.2.0-native-fb-91d097b2-20250701" !==
1905719057
isomorphicReactPackageVersion$jscomp$inline_2261
1905819058
)
1905919059
throw Error(
1906019060
formatProdErrorMessage(
1906119061
527,
1906219062
isomorphicReactPackageVersion$jscomp$inline_2261,
19063-
"19.2.0-native-fb-1e0d12b6-20250630"
19063+
"19.2.0-native-fb-91d097b2-20250701"
1906419064
)
1906519065
);
1906619066
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19082,10 +19082,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1908219082
};
1908319083
var internals$jscomp$inline_2268 = {
1908419084
bundleType: 0,
19085-
version: "19.2.0-native-fb-1e0d12b6-20250630",
19085+
version: "19.2.0-native-fb-91d097b2-20250701",
1908619086
rendererPackageName: "react-dom",
1908719087
currentDispatcherRef: ReactSharedInternals,
19088-
reconcilerVersion: "19.2.0-native-fb-1e0d12b6-20250630",
19088+
reconcilerVersion: "19.2.0-native-fb-91d097b2-20250701",
1908919089
getLaneLabelMap: function () {
1909019090
for (
1909119091
var map = new Map(), lane = 1, index$331 = 0;
@@ -19198,4 +19198,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1919819198
listenToAllSupportedEvents(container);
1919919199
return new ReactDOMHydrationRoot(initialChildren);
1920019200
};
19201-
exports.version = "19.2.0-native-fb-1e0d12b6-20250630";
19201+
exports.version = "19.2.0-native-fb-91d097b2-20250701";

0 commit comments

Comments
 (0)