Skip to content

Commit 2e75000

Browse files
committed
Removed done(), added some comments explaining the change
1 parent 8a6cd3c commit 2e75000

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

packages/react-devtools-extensions/src/injectGlobalHook.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,12 @@ window.addEventListener('message', function(evt) {
3131
reactBuildType: evt.data.reactBuildType,
3232
};
3333
chrome.runtime.sendMessage(lastDetectionResult);
34+
35+
// Inject the backend. This is done in the content script to avoid CSP
36+
// and Trusted Types violations, since content scripts can modify the DOM
37+
// and are not subject to the page's policies
3438
} else if (evt.data.source === 'react-devtools-inject-backend') {
35-
//Inject the specified script
39+
// the prototype stuff is in case document.createElement has been modified
3640
var script = document.constructor.prototype.createElement.call(document, 'script');
3741
script.src = chrome.runtime.getURL('build/backend.js');
3842
script.charset = "utf-8";

packages/react-devtools-extensions/src/main.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -138,14 +138,10 @@ function createPanelIfReactLoaded() {
138138
chrome.devtools.inspectedWindow.eval(
139139
`window.postMessage({ source: 'react-devtools-inject-backend' });`,
140140
function(response, error) {
141-
if (error) {
142-
console.log(error);
143-
}
144-
145-
if (typeof done === 'function') {
146-
done();
141+
if (error) {
142+
console.log(error);
143+
}
147144
}
148-
}
149145
);
150146

151147
const viewElementSourceFunction = createViewElementSource(

0 commit comments

Comments
 (0)