Add setNativeProps to Fabric

Summary:
changelog: Introduce setNativeProps to Fabric

Add support for `setNativeProps` in Fabric for backwards compatibility. It is still recommended to move away from `setNativeProps` because the API will not work with future features.

We can make step [Migrating off setNativeProps](https://reactnative.dev/docs/new-architecture-library-intro#migrating-off-setnativeprops) in migration guide optional.

Reviewed By: yungsters, mdvacca

Differential Revision: D41521523

fbshipit-source-id: 4d9bbd6304b8c5ee24a36b33039ed33ae1fc21f8

Author: sammy-SC

React/Fabric/Mounting/RCTMountingManager.h

@@ -10,6 +10,7 @@
 #import <React/RCTMountingManagerDelegate.h>
 #import <React/RCTPrimitives.h>
 #import <react/renderer/core/ComponentDescriptor.h>
+#import <react/renderer/core/RawProps.h>
 #import <react/renderer/core/ReactPrimitives.h>
 #import <react/renderer/mounting/MountingCoordinator.h>
 #import <react/renderer/mounting/ShadowView.h>
@@ -55,6 +56,13 @@ NS_ASSUME_NONNULL_BEGIN
  */
 - (void)dispatchCommand:(ReactTag)reactTag commandName:(NSString *)commandName args:(NSArray *)args;
 
+/**
+ * Set props on native view directly. It is a performance shortcut that skips render pipeline.
+ * This is a backport of setNativeProps from the old architecture and will be removed in the future.
+ * Can be called from any thread.
+ */
+- (void)setNativeProps_DEPRECATED:(ReactTag)reactTag withProps:(facebook::react::Props::Shared)props;
+
 /**
  * Dispatch an accessibility event to be performed on the main thread.
  * Can be called from any thread.

React/Fabric/Mounting/RCTMountingManager.mm

@@ -225,11 +225,24 @@ - (void)dispatchCommand:(ReactTag)reactTag commandName:(NSString *)commandName a
   }
 
   RCTExecuteOnMainQueue(^{
-    RCTAssertMainQueue();
     [self synchronouslyDispatchCommandOnUIThread:reactTag commandName:commandName args:args];
   });
 }
 
+- (void)setNativeProps_DEPRECATED:(ReactTag)reactTag withProps:(Props::Shared)props
+{
+  if (RCTIsMainQueue()) {
+    UIView<RCTComponentViewProtocol> *componentView = [_componentViewRegistry findComponentViewWithTag:reactTag];
+    Props::Shared oldProps = [componentView props];
+    [componentView updateProps:props oldProps:oldProps];
+    [componentView finalizeUpdates:RNComponentViewUpdateMaskProps];
+    return;
+  }
+  RCTExecuteOnMainQueue(^{
+    [self setNativeProps_DEPRECATED:reactTag withProps:std::move(props)];
+  });
+}
+
 - (void)sendAccessibilityEvent:(ReactTag)reactTag eventType:(NSString *)eventType
 {
   if (RCTIsMainQueue()) {
@@ -241,7 +254,6 @@ - (void)sendAccessibilityEvent:(ReactTag)reactTag eventType:(NSString *)eventTyp
   }
 
   RCTExecuteOnMainQueue(^{
-    RCTAssertMainQueue();
     [self synchronouslyDispatchAccessbilityEventOnUIThread:reactTag eventType:eventType];
   });
 }

React/Fabric/RCTScheduler.h

@@ -34,6 +34,9 @@ NS_ASSUME_NONNULL_BEGIN
                         commandName:(std::string const &)commandName
                                args:(folly::dynamic const &)args;
 
+- (void)setNativeProps_DEPRECATED:(facebook::react::ShadowView const &)shadowView
+                        withProps:(facebook::react::Props::Shared)props;
+
 - (void)schedulerDidSendAccessibilityEvent:(facebook::react::ShadowView const &)shadowView
                                  eventType:(std::string const &)eventType;
 

React/Fabric/RCTScheduler.mm

@@ -45,6 +45,12 @@ void schedulerDidDispatchCommand(
     [scheduler.delegate schedulerDidDispatchCommand:shadowView commandName:commandName args:args];
   }
 
+  void setNativeProps_DEPRECATED(const ShadowView &shadowView, Props::Shared props) override
+  {
+    RCTScheduler *scheduler = (__bridge RCTScheduler *)scheduler_;
+    [scheduler.delegate setNativeProps_DEPRECATED:shadowView withProps:std::move(props)];
+  }
+
   void schedulerDidSetIsJSResponder(ShadowView const &shadowView, bool isJSResponder, bool blockNativeResponder)
       override
   {

React/Fabric/RCTSurfacePresenter.mm

@@ -372,6 +372,12 @@ - (void)schedulerDidDispatchCommand:(ShadowView const &)shadowView
   [_mountingManager dispatchCommand:tag commandName:commandStr args:argsArray];
 }
 
+- (void)setNativeProps_DEPRECATED:(ShadowView const &)shadowView withProps:(Props::Shared)props
+{
+  ReactTag tag = shadowView.tag;
+  [self->_mountingManager setNativeProps_DEPRECATED:tag withProps:props];
+}
+
 - (void)schedulerDidSendAccessibilityEvent:(const facebook::react::ShadowView &)shadowView
                                  eventType:(const std::string &)eventType
 {

ReactAndroid/src/main/jni/react/fabric/Binding.cpp

@@ -549,6 +549,12 @@ void Binding::schedulerDidDispatchCommand(
   mountingManager->dispatchCommand(shadowView, commandName, args);
 }
 
+void Binding::setNativeProps_DEPRECATED(
+    const ShadowView &shadowView,
+    Props::Shared props) {
+  // TODO(T130729920): Add Android implementation for setNativeProps.
+}
+
 void Binding::schedulerDidSendAccessibilityEvent(
     const ShadowView &shadowView,
     std::string const &eventType) {

ReactAndroid/src/main/jni/react/fabric/Binding.h

@@ -107,6 +107,10 @@ class Binding : public jni::HybridClass<Binding>,
       std::string const &commandName,
       folly::dynamic const &args) override;
 
+  void setNativeProps_DEPRECATED(
+      const ShadowView &shadowView,
+      Props::Shared props) override;
+
   void schedulerDidSendAccessibilityEvent(
       const ShadowView &shadowView,
       std::string const &eventType) override;

ReactCommon/react/renderer/components/view/YogaLayoutableShadowNode.cpp

@@ -202,6 +202,7 @@ void YogaLayoutableShadowNode::adoptYogaChild(size_t index) {
     // react_native_assert(layoutableChildNode.yogaNode_.isDirty());
   } else {
     // The child is owned by some other node, we need to clone that.
+    // TODO: At this point, React has wrong reference to the node. (T138668036)
     auto clonedChildNode = childNode.clone({});
     auto &layoutableClonedChildNode =
         traitCast<YogaLayoutableShadowNode const &>(*clonedChildNode);

ReactCommon/react/renderer/core/DynamicPropsUtilities.cpp

@@ -8,6 +8,7 @@
 #include "DynamicPropsUtilities.h"
 
 namespace facebook::react {
+
 folly::dynamic mergeDynamicProps(
     folly::dynamic const &source,
     folly::dynamic const &patch) {
@@ -30,4 +31,8 @@ folly::dynamic mergeDynamicProps(
   return result;
 }
 
+RawProps mergeRawProps(folly::dynamic const &source, RawProps const &patch) {
+  return {mergeDynamicProps((folly::dynamic)source, (folly::dynamic)patch)};
+}
+
 } // namespace facebook::react

ReactCommon/react/renderer/core/DynamicPropsUtilities.h

@@ -8,13 +8,14 @@
 #pragma once
 
 #include <folly/dynamic.h>
+#include <react/renderer/core/RawProps.h>
 
-namespace facebook {
-namespace react {
+namespace facebook::react {
 
 folly::dynamic mergeDynamicProps(
     folly::dynamic const &source,
     folly::dynamic const &patch);
 
-} // namespace react
-} // namespace facebook
+RawProps mergeRawProps(folly::dynamic const &source, RawProps const &patch);
+
+} // namespace facebook::react