-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Exercise Instructions, Intros, Metadata] Sync to problem specs #3396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Should maybe wait for exercism/problem-specifications#2261 to get merged. |
ee7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should maybe wait for exercism/problem-specifications#2261 to get merged.
I agree.
I'd suggest waiting for exercism/problem-specifications#2264 too, assuming I'm not mistaken about it.
At the time of writing, this PR is only missing exercism/problem-specifications@3f7284e, (which was merged after this PR was created):
$ git rev-parse --short HEAD
c875cb98
$ bin/configlet --version
4.0.0-beta.10
$ bin/configlet sync --docs --metadata
Updating cached 'problem-specifications' data...
Checking exercises...
[warn] docs: instructions unsynced: sum-of-multiples
[warn] some exercises have unsynced docs|
I am confused. The diff suggests that e.g. the Sum of Multiples instructions will be replaced, however it seems that they already have been. |
It's because this PR is one commit behind |
|
I'm going to merge #3398, and wait for exercism/problem-specifications#2264. This PR is 'regular maintenance', not a big rush, and can easily be re-done or rebased when the dust settles.....'' |
|
What, then, does the diff mean? I thought it was comparing both branches' heads, but now it seems it actually isn't. |
|
Actually, I am going to close this for now. The velocity of change has picked up, and it is probably easier to wait for a slowdown and then re-run configlet to pick up any 'hanging' changes. I was primarily doing this to work on |
From the GitHub docs, the diff shown when clicking "Files changed" in a PR is:
This means, for example, the diff shown in a PR stays the same when:
Further rationale from the same page:
|
|
@ee7 Sorry, I didn't see your comment until now. I think I get it now, thanks.
|
Used
configlet 4.0.0-beta.10to sync exercises to problem specifications.This seems like a pretty large list, so I am not sure if something went wrong, or there are very small changes that were picked up by configlet that weren't there last month.
edited to add -- the bulk of these look like one sentence per line edits and other small tidyings.
.docschanges:new file: exercises/practice/largest-series-product/.docs/introduction.mdnew file: exercises/practice/rna-transcription/.docs/introduction.mdnew file: exercises/practice/saddle-points/.docs/introduction.mdnew file: exercises/practice/sum-of-multiples/.docs/introduction.mdmetadatachanges: