Skip to content

Conversation

@ErikSchierboom
Copy link
Member

No description provided.

@ErikSchierboom ErikSchierboom requested a review from a team as a code owner March 22, 2023 11:00

The outer circle has a radius of 10 units (this is equivalent to the total radius for the entire target), the middle circle a radius of 5 units, and the inner circle a radius of 1.
Of course, they are all centered at the same point (that is, the circles are [concentric][] defined by the coordinates (0, 0).
Of course, they are all centered at the same point (that is, the circles are [concentric][] defined by the coordinates (0, 0)).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could argue that this makes it less readable. Let me know what you all think

Copy link
Member

@kytrinyx kytrinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. If we don't do this we should at least remove the opening one!

@glennj
Copy link
Contributor

glennj commented Mar 22, 2023

A semicolon works here, I think:

Of course, they are all centered at the same point; that is, the circles are [concentric][] defined by the coordinates (0, 0).

or a hyphen.

@ErikSchierboom ErikSchierboom changed the title darts: add missing closing parenthesis darts: fix missing closing parenthesis Mar 28, 2023
@ErikSchierboom ErikSchierboom merged commit f771129 into main Mar 28, 2023
@ErikSchierboom ErikSchierboom deleted the darts-add-missing-closing-parenthesis branch March 28, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants