-
-
Notifications
You must be signed in to change notification settings - Fork 144
Sync wordy #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync wordy #932
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks nice!
Run
bin/configlet sync -u -e wordy --yes --docs --filepaths --metadata --tests include(updates the Markdown files and maybetests.toml)Drop strict types comments from test file and example code (these are useless)
Add and sync test meta data to tests (
uuidin DocBlocks /#TestDox())Add exercise to
bin/auto-sync.txtto keep it in sync (keep the file alphabetically sorted)Decide on adding / adjusting / ordering test cases to match current problem specs
Breaking:
'just a number''just a zero''just a negative number'Non-breaking:
'addition with a left hand zero''addition with a right hand zero''reject problem missing an operand''reject problem with no operands or operators''reject two operations in a row''reject two numbers in a row''reject postfix notation''reject prefix notation'326 started, 213 solutions -> I think it is OK to break them. Single number is a reasonable requirement, that's not too hard.
Raise difficulty to
5(medium). It was1(easy), which it is not. There is a complicated RegEx or some character-based parsing involved -> medium at least.