fix: correctly combine address and contract address list in event filter param construction

[Aerilym]

What was wrong?

Related to Issue #3617
Closes #3617

How was it fixed?

See description of #3617

Todo:

• Clean up commit history
• Add or update documentation related to these changes
• Add entry to the release notes

Cute Animal Picture

[Aerilym]

Put a lot of details in the issue #3617 happy to expand on it or add more to this contribution. This just fixed my issue for what I'm doing so thought I'd get the ball rolling

[Aerilym]

I made a change to make sure the final output works if you have address and/or contract_address as a list or string. Also de-duplicated but just using address if they're the same. Also had to do some gymnastics to get the linter to like the type hints, not sure if that resulted in the best solution.

[Aerilym]

The linting is still unhappy, would love some direction on how you want the type hinting to work in this section? as there is no type assertion in if blocks it seems overly strict

[reedsa]

@Aerilym Thanks for the contribution here and apologies for being slow to respond here! I figured out a way to make types cooperate and also make the validation simpler. Have a look and let us know if there's anything further you'd like to add.

[kclowes]

LGTM, just left one question!

[Aerilym]

@Aerilym Thanks for the contribution here and apologies for being slow to respond here! I figured out a way to make types cooperate and also make the validation simpler. Have a look and let us know if there's anything further you'd like to add.

Thanks for picking up this PR, we've been using these changes in production had no issues. Can't think of any other related changes needed.

[fselmo]

@reedsa nice elegant solution with the set check, lgtm 👍🏼