Deprecate async get_uncle* methods

Author: tibor-reiss

web3/_utils/module_testing/eth_module.py

@@ -2172,19 +2172,27 @@ async def test_eth_getBlockTransactionCountByHash_block_with_txn(
     async def test_eth_getUncleCountByBlockHash(
         self, async_w3: "AsyncWeb3", async_empty_block: BlockData
     ) -> None:
-        uncle_count = await async_w3.eth.get_uncle_count(async_empty_block["hash"])
+        with pytest.warns(
+            DeprecationWarning, match=r"All get_uncle\* methods have been deprecated"
+        ):
+            uncle_count = await async_w3.eth.get_uncle_count(async_empty_block["hash"])
 
-        assert is_integer(uncle_count)
-        assert uncle_count == 0
+            assert is_integer(uncle_count)
+            assert uncle_count == 0
 
     @pytest.mark.asyncio
     async def test_eth_getUncleCountByBlockNumber(
         self, async_w3: "AsyncWeb3", async_empty_block: BlockData
     ) -> None:
-        uncle_count = await async_w3.eth.get_uncle_count(async_empty_block["number"])
+        with pytest.warns(
+            DeprecationWarning, match=r"All get_uncle\* methods have been deprecated"
+        ):
+            uncle_count = await async_w3.eth.get_uncle_count(
+                async_empty_block["number"]
+            )
 
-        assert is_integer(uncle_count)
-        assert uncle_count == 0
+            assert is_integer(uncle_count)
+            assert uncle_count == 0
 
     @pytest.mark.asyncio
     async def test_eth_getBlockTransactionCountByNumber_block_with_txn(

web3/eth/async_eth.py

@@ -71,6 +71,7 @@
     Web3ValueError,
 )
 from web3.method import (
+    DeprecatedMethod,
     Method,
     default_root_munger,
 )
@@ -660,14 +661,20 @@ async def sign_typed_data(
     # eth_getUncleCountByBlockHash
     # eth_getUncleCountByBlockNumber
 
-    _get_uncle_count: Method[Callable[[BlockIdentifier], Awaitable[int]]] = Method(
+    __get_uncle_count: Method[Callable[[BlockIdentifier], Awaitable[int]]] = Method(
         method_choice_depends_on_args=select_method_for_block_identifier(
             if_predefined=RPC.eth_getUncleCountByBlockNumber,
             if_hash=RPC.eth_getUncleCountByBlockHash,
             if_number=RPC.eth_getUncleCountByBlockNumber,
         ),
         mungers=[default_root_munger],
     )
+    _get_uncle_count = DeprecatedMethod(
+        __get_uncle_count,
+        old_name="__get_uncle_count",
+        new_name="_get_uncle_count",
+        msg="All get_uncle* methods have been deprecated",
+    )
 
     async def get_uncle_count(self, block_identifier: BlockIdentifier) -> int:
         return await self._get_uncle_count(block_identifier)