Skip to content

Conversation

@obscuren
Copy link
Contributor

@obscuren obscuren commented Aug 9, 2015

No description provided.

@robotally
Copy link

Vote Count Reviewers
👍 0
👎 0

Updated: Sun Aug 9 00:06:50 UTC 2015

obscuren added a commit that referenced this pull request Aug 9, 2015
cmd/geth, core/vm: setup vm settings and defaulted JIT disabled
@obscuren obscuren merged commit 1cbd53a into ethereum:develop Aug 9, 2015
@obscuren obscuren removed the review label Aug 9, 2015
@obscuren obscuren deleted the defaults-fix branch August 9, 2015 00:12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider changing the name away from the negative, i.g. EnableJit bool = false

Turning a flag on to disable a feature is conceptually strange

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I'll have to submit a future PR for this. There are issues with the VM anyhow

@obscuren obscuren modified the milestone: 1.0.2 Aug 15, 2015
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Jul 21, 2023
…lter (ethereum#25186) (ethereum#1626)

This PR adds a way to subscribe to the _full_ pending transactions, as opposed to just being notified about hashes.

In use cases where client subscribes to newPendingTransactions and gets txhashes only to then request the actual transaction, the caller can now shortcut that flow and obtain the transactions directly.

Co-authored-by: lx <[email protected]>
Co-authored-by: lmittmann <[email protected]>
Co-authored-by: Felix Lange <[email protected]>
codegen-sh bot pushed a commit to streamingfast/go-ethereum that referenced this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants