CL-EL withdrawals harmonization: using units of Gwei #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
See EIP update here: ethereum/EIPs#6325 |
timbeiko
reviewed
Jan 12, 2023
mkalinin
approved these changes
Jan 13, 2023
yperbasis
approved these changes
Jan 13, 2023
djrtwo
approved these changes
Jan 13, 2023
Contributor
djrtwo
left a comment
djrtwo
left a comment
There was a problem hiding this comment.
looks good! not sure why line 146 is in the diff though
Contributor
|
lgtm |
tersec
added a commit
to status-im/nim-web3
that referenced
this pull request
Jan 14, 2023
tersec
added a commit
to status-im/nim-eth
that referenced
this pull request
Jan 14, 2023
tersec
added a commit
to status-im/nim-eth
that referenced
this pull request
Jan 14, 2023
This was referenced Jan 14, 2023
etan-status
approved these changes
Jan 14, 2023
Contributor
etan-status
left a comment
etan-status
left a comment
There was a problem hiding this comment.
Thanks for this. This will allow eventually migrating the EL's withdrawals_root and txs_root to SSZ, eliminating the inconsistency with CL ExecutionPayloadHeader values.
etan-status
added a commit
to etan-status/consensus-specs
that referenced
this pull request
Jan 15, 2023
Updates the EL block hash computation for pytests to match latest spec. Notably, use `Gwei` for `Withdrawal` amount consistently. Also fix `excess_data_gas` not being correctly accounted for. ethereum/execution-apis#354 ethereum/EIPs#6325
potuz
approved these changes
Jan 16, 2023
Contributor
potuz
left a comment
potuz
left a comment
There was a problem hiding this comment.
Can we get this merged today so that we can merge in production and use production code in the devnet?
2 tasks
tersec
approved these changes
Jan 16, 2023
lightclient
approved these changes
Jan 17, 2023
yperbasis
added a commit
to erigontech/erigon
that referenced
this pull request
Jan 17, 2023
green-solidityethan890
added a commit
to green-solidityethan890/nim-eth
that referenced
this pull request
Sep 29, 2025
hacker-nova7431
added a commit
to hacker-nova7431/nim-eth
that referenced
this pull request
Sep 29, 2025
git-ravenbin
added a commit
to git-ravenbin/nim-web3
that referenced
this pull request
Oct 26, 2025
platform-dragonmk90
added a commit
to platform-dragonmk90/nim-eth
that referenced
this pull request
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion from here ethereum/pm#702, protocol devs want to explore harmonization in the withdrawals format from CL to EL.
This PR updates the Engine API with the first part of this change to use the same units (
Gwei) for theamountin each withdrawal.