Skip to content

Conversation

@alcueca
Copy link
Contributor

@alcueca alcueca commented Sep 30, 2025

Fixes this task by removing upgradeController from OPCM, now that it is not used anymore.

Outside OPCM, upgradeController becomes l1PAO, which is the same thing, but in a more recognizable name.

@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.99%. Comparing base (3ee883b) to head (182a644).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17660      +/-   ##
===========================================
+ Coverage    74.83%   80.99%   +6.15%     
===========================================
  Files          173      118      -55     
  Lines        11064     6278    -4786     
===========================================
- Hits          8280     5085    -3195     
+ Misses        2638     1193    -1445     
+ Partials       146        0     -146     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 80.99% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...es/contracts-bedrock/src/L1/OPContractsManager.sol 96.32% <100.00%> (-0.01%) ⬇️

... and 55 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alcueca alcueca marked this pull request as ready for review October 2, 2025 15:19
@alcueca alcueca requested review from a team as code owners October 2, 2025 15:20
Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very happy about this change!

@mds1 mds1 added this pull request to the merge queue Oct 6, 2025
Merged via the queue into develop with commit 5e38a4f Oct 6, 2025
69 checks passed
@mds1 mds1 deleted the alcueca/remove-upgrade-controller branch October 6, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants