-
Notifications
You must be signed in to change notification settings - Fork 3.8k
op-sync-tester: Verifier Engine APIs for Ecotone, Fjord, Granite, Holocene #17181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pcw109550
merged 2 commits into
develop
from
pcw109550/sync-tester-verifier-engine-rpcs-all
Aug 22, 2025
Merged
op-sync-tester: Verifier Engine APIs for Ecotone, Fjord, Granite, Holocene #17181
pcw109550
merged 2 commits into
develop
from
pcw109550/sync-tester-verifier-engine-rpcs-all
Aug 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #17181 +/- ##
============================================
- Coverage 78.32% 0 -78.33%
============================================
Files 163 0 -163
Lines 9709 0 -9709
============================================
- Hits 7605 0 -7605
+ Misses 1958 0 -1958
+ Partials 146 0 -146
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
0d60e8e to
e64e799
Compare
1419ae0 to
144180f
Compare
3 tasks
3 tasks
3 tasks
nonsense
reviewed
Aug 22, 2025
nonsense
approved these changes
Aug 22, 2025
Base automatically changed from
pcw109550/sync-tester-verifier-engine-rpcs
to
develop
August 22, 2025 12:24
f1b1830 to
1a9ee54
Compare
3 tasks
leopoldjoy
pushed a commit
to leopoldjoy/optimism
that referenced
this pull request
Aug 22, 2025
…ocene (ethereum-optimism#17181) * Support fjord, granite, holocene * Revise comments
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
NewPayloadV3,GetPayloadV3and fixesForkchoiceUpdatedV3,NewPayloadV4,GetPayloadV4to support for Ecotone, Fjord, Granite, Holocene hardforks.Note that different versions per same API may have similar code flow so made them DRY.
Tests
There are no unit tests and acceptance test yet. But I validated the sync tester using the local kurtosis devnet, which enables each hardfork like
via editing the kt yaml.
Also poured user tx using tx-fuzzer while testing syncing.
Exactly equal testing method from #17072
The reason why I could not test the other hardforks like ecotone activation + delta + canyon is that the kurtosis devnet does not support these to be configurable. Hopefully we can do this in sysgo which is currently work in progress.
Additional context
While testing, I found out that the op-node fills in withdrawals root inside
ExecutionPayloadeven if we are pre-isthmus. Spec. Need to investigate why.Metadata