Skip to content

Conversation

@pcw109550
Copy link
Contributor

@pcw109550 pcw109550 commented Aug 22, 2025

Description

Adds NewPayloadV3, GetPayloadV3 and fixes ForkchoiceUpdatedV3, NewPayloadV4, GetPayloadV4 to support for Ecotone, Fjord, Granite, Holocene hardforks.

Note that different versions per same API may have similar code flow so made them DRY.

Tests

There are no unit tests and acceptance test yet. But I validated the sync tester using the local kurtosis devnet, which enables each hardfork like

        fjord_time_offset: 0
        granite_time_offset: 120
        holocene_time_offset: 180
        isthmus_time_offset: 240

via editing the kt yaml.

Also poured user tx using tx-fuzzer while testing syncing.

Exactly equal testing method from #17072

The reason why I could not test the other hardforks like ecotone activation + delta + canyon is that the kurtosis devnet does not support these to be configurable. Hopefully we can do this in sysgo which is currently work in progress.

Additional context

While testing, I found out that the op-node fills in withdrawals root inside ExecutionPayload even if we are pre-isthmus. Spec. Need to investigate why.

Metadata

@pcw109550 pcw109550 changed the title op-sync-tester: Support fjord, granite, holocene op-sync-tester: Verifier Engine APIs for Fjord, Granite, Holocene Aug 22, 2025
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (477692e) to head (1a9ee54).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #17181       +/-   ##
============================================
- Coverage    78.32%        0   -78.33%     
============================================
  Files          163        0      -163     
  Lines         9709        0     -9709     
============================================
- Hits          7605        0     -7605     
+ Misses        1958        0     -1958     
+ Partials       146        0      -146     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 163 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcw109550 pcw109550 force-pushed the pcw109550/sync-tester-verifier-engine-rpcs branch from 0d60e8e to e64e799 Compare August 22, 2025 11:07
@pcw109550 pcw109550 force-pushed the pcw109550/sync-tester-verifier-engine-rpcs-all branch from 1419ae0 to 144180f Compare August 22, 2025 11:30
@pcw109550 pcw109550 changed the title op-sync-tester: Verifier Engine APIs for Fjord, Granite, Holocene op-sync-tester: Verifier Engine APIs for Ecotone, Fjord, Granite, Holocene Aug 22, 2025
@pcw109550 pcw109550 requested a review from nonsense August 22, 2025 11:53
@pcw109550 pcw109550 marked this pull request as ready for review August 22, 2025 12:01
@pcw109550 pcw109550 requested a review from a team as a code owner August 22, 2025 12:01
@pcw109550 pcw109550 linked an issue Aug 22, 2025 that may be closed by this pull request
3 tasks
@pcw109550 pcw109550 linked an issue Aug 22, 2025 that may be closed by this pull request
3 tasks
Base automatically changed from pcw109550/sync-tester-verifier-engine-rpcs to develop August 22, 2025 12:24
@pcw109550 pcw109550 force-pushed the pcw109550/sync-tester-verifier-engine-rpcs-all branch from f1b1830 to 1a9ee54 Compare August 22, 2025 12:34
@pcw109550 pcw109550 added this pull request to the merge queue Aug 22, 2025
Merged via the queue into develop with commit aafa23a Aug 22, 2025
64 of 65 checks passed
@pcw109550 pcw109550 deleted the pcw109550/sync-tester-verifier-engine-rpcs-all branch August 22, 2025 13:31
leopoldjoy pushed a commit to leopoldjoy/optimism that referenced this pull request Aug 22, 2025
…ocene (ethereum-optimism#17181)

* Support fjord, granite, holocene

* Revise comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

op-sync-tester: Support engine namespace

3 participants