Skip to content

update conductor scenario when builder failure #17158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 20, 2025
Merged

update conductor scenario when builder failure #17158

merged 4 commits into from
Aug 20, 2025
+63 −4

Conversation

@cody-wang-cb
Copy link
Contributor

@cody-wang-cb cody-wang-cb commented Aug 20, 2025 •
edited
Loading

Description
This fixes a scenario where

  • A sequencer is healthy itself but its builder is not healthy, rollupboost healthcheck enabled
  • Leadership transfer happened it transferred to this sequencer
  • This sequencer has state (leader: true, healthy: false, active: true) with previous state (leader: true, healthy:false, active:false)
  • In this case, leadership is stuck in this sequencer as it keeps on waiting for itself to become healthy, when it's supposed to transfer leader because its builder is unhealthy

Adding the check so that if the unhealthy is due to builder failure and rollupboost healthcheck is enabled, it'll transfer the leader as well.

Tests

Additional context

Metadata

@cody-wang-cb cody-wang-cb requested review from a team as code owners August 20, 2025 00:02
@cody-wang-cb cody-wang-cb requested a review from zhwrd August 20, 2025 00:02
@zhwrd
Copy link
Contributor

zhwrd commented Aug 20, 2025

/ci authorize b130093

@zhwrd zhwrd added this pull request to the merge queue Aug 20, 2025
Merged via the queue into ethereum-optimism:develop with commit a4275c9 Aug 20, 2025
69 checks passed
leopoldjoy pushed a commit to leopoldjoy/optimism that referenced this pull request Aug 22, 2025
@cody-wang-cb @leopoldjoy
update conductor scenario when builder failure (ethereum-optimism#17158)
ba9fd6e 
* update conductor scenario when builder failure

* check for rollup boost enabled

* modify comments

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhwrd zhwrd zhwrd approved these changes

@0x00101010 0x00101010 0x00101010 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cody-wang-cb @zhwrd @0x00101010