Skip to content

chore: use conventional commits #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 19, 2021
Merged

chore: use conventional commits #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b58d0de
chore: auto-changelog => conventional-changelog (fixes #220)
aladdin-add Oct 18, 2021
efa1c03
docs: add conventional commits badge
aladdin-add Oct 18, 2021
173a85d
chore: add commitlint
aladdin-add Oct 18, 2021
d76f265
chore: add husky commit-msg
aladdin-add Oct 18, 2021
a91f546
chore: npm scripts generate-release => release
aladdin-add Oct 18, 2021
5864f59
chore: fix commit msg
aladdin-add Oct 18, 2021
dbe0518
fix: angular to conventionalcommits
aladdin-add Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .husky/commit-msg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npx --no-install commitlint --edit ""
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# eslint-plugin-eslint-plugin ![CI](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/workflows/CI/badge.svg) [![NPM version](https://img.shields.io/npm/v/eslint-plugin-eslint-plugin.svg?style=flat)](https://npmjs.org/package/eslint-plugin-eslint-plugin)
# eslint-plugin-eslint-plugin ![CI](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/workflows/CI/badge.svg) [![NPM version](https://img.shields.io/npm/v/eslint-plugin-eslint-plugin.svg?style=flat)](https://npmjs.org/package/eslint-plugin-eslint-plugin) [![Conventional Commits](https://img.shields.io/badge/Conventional%20Commits-1.0.0-yellow.svg)](https://conventionalcommits.org)

An ESLint plugin for linting ESLint plugins. Rules written in CJS, ESM, and TypeScript are all supported.

Expand Down
3 changes: 3 additions & 0 deletions commitlint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
'use strict';

module.exports = { extends: ['@commitlint/config-conventional'] };
16 changes: 13 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"lint:docs": "markdownlint '**/*.md'",
"lint:js": "eslint .",
"generate-readme-table": "node build/generate-readme-table.js",
"generate-release": "release-it",
"release": "release-it",
"test": "nyc --all --check-coverage --include lib mocha tests --recursive"
},
"files": [
Expand Down Expand Up @@ -40,6 +40,9 @@
"statements": 99
},
"devDependencies": {
"@commitlint/cli": "^13.2.1",
"@commitlint/config-conventional": "^13.2.0",
"@release-it/conventional-changelog": "^3.3.0",
"@typescript-eslint/parser": "^5.0.0",
"auto-changelog": "^2.3.0",
"chai": "^4.1.0",
Expand All @@ -52,6 +55,7 @@
"eslint-plugin-unicorn": "^37.0.0",
"eslint-scope": "^6.0.0",
"espree": "^9.0.0",
"husky": "^7.0.2",
"lodash": "^4.17.2",
"markdownlint-cli": "^0.28.1",
"mocha": "^9.1.2",
Expand All @@ -67,8 +71,14 @@
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
},
"release-it": {
"hooks": {
"after:bump": "auto-changelog -p"
"git": {
"commitMessage": "chore: release v${version}"
},
"plugins": {
"@release-it/conventional-changelog": {
"preset": "conventionalcommits",
"infile": "CHANGELOG.md"
}
},
"github": {
"release": true
Expand Down