Skip to content

Commit 42c537d

Browse files
committed
fix: add missing isUserOpValidation to ValidationDataView in spec
1 parent 2eccf6a commit 42c537d

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/interfaces/IModularAccountView.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ struct ValidationDataView {
2424
bool isGlobal;
2525
// Whether or not this validation function is a signature validator.
2626
bool isSignatureValidation;
27-
// Whether or not this validation is a user operation validator.
27+
// Whether or not this validation function is a user operation validation function.
2828
bool isUserOpValidation;
2929
// The pre validation hooks for this validation function.
3030
ModuleEntity[] preValidationHooks;

standard/ERCs/erc-6900.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,8 @@ struct ValidationDataView {
243243
bool isGlobal;
244244
// Whether or not this validation function is a signature validator.
245245
bool isSignatureValidation;
246+
// Whether or not this validation function is a user operation validation function.
247+
bool isUserOpValidation;
246248
// The pre validation hooks for this validation function.
247249
ModuleEntity[] preValidationHooks;
248250
// Execution hooks to run with this validation function.
@@ -551,7 +553,7 @@ User op validation and runtime validation functions have a configurable range of
551553

552554
If the selector being checked is `execute` or `executeBatch`, the modular account MUST perform additional checking. If the target of `execute` is the modular account's own address, or if the target of any `Call` within `executeBatch` is the account, validation MUST either revert or check that validation applies to the selector(s) being called.
553555

554-
Installed validation functions have two flag variables indicating what they may be used for. If a validation function is attempted to be used for user op validation and the flag `isUserOpValidation` is set to false, validation MUST revert. If the validation function is attempted to be used for signature validation and the flag `isSignatureValidation` is set to false, validation MUST revert.
556+
Installed validation functions have two additional flag variables indicating what they may be used for. If a validation function is attempted to be used for user op validation and the flag `isUserOpValidation` is set to false, validation MUST revert. If the validation function is attempted to be used for signature validation and the flag `isSignatureValidation` is set to false, validation MUST revert.
555557

556558
#### Direct Call Validation
557559

0 commit comments

Comments
 (0)