Skip to content

Conversation

@leunge
Copy link
Contributor

@leunge leunge commented Mar 29, 2023

ImgBotApp and others added 30 commits February 1, 2023 16:58
*Total -- 970.05kb -> 157.61kb (83.75%)

/images/block_icon/hardware_bzr2.svg -- 247.28kb -> 0.91kb (99.63%)
/images/block_icon/hardware_dc.svg -- 248.25kb -> 1.61kb (99.35%)
/images/block_icon/hardware_led.svg -- 249.30kb -> 1.90kb (99.24%)
/images/hw/iCOBOT_Front.png -- 174.26kb -> 105.80kb (39.28%)
/images/beta_tag.svg -- 0.43kb -> 0.34kb (20.67%)
/images/hardware/KKMOO.png -- 50.53kb -> 47.05kb (6.89%)

Signed-off-by: ImgBotApp <[email protected]>
- 이벤트블럭 하위에 하드웨어 블록 붙일떄, 최적화 필요
코알라보드(헬로긱스) 추가
RobokitRS 추가 및 기존 하드웨어 수정
@leunge leunge merged commit 0a13d11 into master Mar 29, 2023
try {
await Promise.all(this.execPromises);
} catch (e) {}
} catch (e) { }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·

Suggested change
} catch (e) { }
} catch (e) {}

resolve(null);
}
);
Entry.modal.alert(content, title, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎····················

Suggested change
Entry.modal.alert(content, title, {
Entry.moda
l.alert(content, title, {

}
);
Entry.modal.alert(content, title, {
withDontShowAgain: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace withDontShowAgain:·true with ····withDontShowAgain:·true,

Suggested change
withDontShowAgain: true
withDontShowAgain: true,e

Comment on lines +638 to +639
withDontShowAgain: true
}).then((data: { dontShowChecked: boolean }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ················}) with ····················})⏎····················

Suggested change
withDontShowAgain: true
}).then((data: { dontShowChecked: boolean }) => {
withDontShowAgain: true })
).then((data: { dontShowChecked: boolean }) => {

Entry.modal.alert(content, title, {
withDontShowAgain: true
}).then((data: { dontShowChecked: boolean }) => {
const { dontShowChecked } = data || {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····

Suggested change
const { dontShowChecked } = data || {};
const { dontShowChecked } = data || {};

}

getBlocks = function() {
getBlocks = function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Suggested change
getBlocks = function () {
getBlocks = function() {

},
],
def: {
type: 'microbit2lite_btn_event'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ,

Suggested change
type: 'microbit2lite_btn_event'
type: 'microbit2lite_btn_event',

Comment on lines +1963 to +1965
func: (sprite, script) => {
return script.callReturn();
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <arrow-body-style> reported by reviewdog 🐶
Unexpected block statement surrounding arrow body; move the returned value immediately after the =>.

Suggested change
func: (sprite, script) => {
return script.callReturn();
},
func: (sprite, script) => script.callReturn(),

contentResult += `${this.Block(block)}\n`;
try {
if (index === 0 && Entry.TextCodingUtil.isEventBlock(block)) {
rootResult = `${this.Block(block)}\n`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <new-cap> reported by reviewdog 🐶
A function with a name starting with an uppercase letter should only be used as a constructor.

if (index === 0 && Entry.TextCodingUtil.isEventBlock(block)) {
rootResult = `${this.Block(block)}\n`;
} else {
contentResult += `${this.Block(block)}\n`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <new-cap> reported by reviewdog 🐶
A function with a name starting with an uppercase letter should only be used as a constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants