-
Notifications
You must be signed in to change notification settings - Fork 496
운영반영 4.23.0 #2474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
운영반영 4.23.0 #2474
Conversation
*Total -- 970.05kb -> 157.61kb (83.75%) /images/block_icon/hardware_bzr2.svg -- 247.28kb -> 0.91kb (99.63%) /images/block_icon/hardware_dc.svg -- 248.25kb -> 1.61kb (99.35%) /images/block_icon/hardware_led.svg -- 249.30kb -> 1.90kb (99.24%) /images/hw/iCOBOT_Front.png -- 174.26kb -> 105.80kb (39.28%) /images/beta_tag.svg -- 0.43kb -> 0.34kb (20.67%) /images/hardware/KKMOO.png -- 50.53kb -> 47.05kb (6.89%) Signed-off-by: ImgBotApp <[email protected]>
- 이벤트블럭 하위에 하드웨어 블록 붙일떄, 최적화 필요
코알라보드(헬로긱스) 추가
RobokitRS 추가 및 기존 하드웨어 수정
Issue/5899 2
비트브릭 블록 오류 수정
Issue/5643
Issue/5899
[#5764] 신규 판단, 값블록 구현
[5760] 하드웨어 최소버전안내문구 entrylms => modal로 변경
- 다국어, 블록메뉴 위치 수정
[#5764] 신규 판단, 값블록 구현 추가 수정
[4.23.0] 하드웨어 1.9.40 PR
[ImgBot] Optimize images
| try { | ||
| await Promise.all(this.execPromises); | ||
| } catch (e) {} | ||
| } catch (e) { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
| } catch (e) { } | |
| } catch (e) {} |
| resolve(null); | ||
| } | ||
| ); | ||
| Entry.modal.alert(content, title, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎····················
| Entry.modal.alert(content, title, { | |
| Entry.moda | |
| l.alert(content, title, { |
| } | ||
| ); | ||
| Entry.modal.alert(content, title, { | ||
| withDontShowAgain: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace withDontShowAgain:·true with ····withDontShowAgain:·true,
| withDontShowAgain: true | |
| withDontShowAgain: true,e |
| withDontShowAgain: true | ||
| }).then((data: { dontShowChecked: boolean }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ················}) with ····················})⏎····················
| withDontShowAgain: true | |
| }).then((data: { dontShowChecked: boolean }) => { | |
| withDontShowAgain: true }) | |
| ).then((data: { dontShowChecked: boolean }) => { |
| Entry.modal.alert(content, title, { | ||
| withDontShowAgain: true | ||
| }).then((data: { dontShowChecked: boolean }) => { | ||
| const { dontShowChecked } = data || {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····
| const { dontShowChecked } = data || {}; | |
| const { dontShowChecked } = data || {}; |
| } | ||
|
|
||
| getBlocks = function() { | ||
| getBlocks = function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected space before function parentheses.
| getBlocks = function () { | |
| getBlocks = function() { |
| }, | ||
| ], | ||
| def: { | ||
| type: 'microbit2lite_btn_event' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ,
| type: 'microbit2lite_btn_event' | |
| type: 'microbit2lite_btn_event', |
| func: (sprite, script) => { | ||
| return script.callReturn(); | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected block statement surrounding arrow body; move the returned value immediately after the =>.
| func: (sprite, script) => { | |
| return script.callReturn(); | |
| }, | |
| func: (sprite, script) => script.callReturn(), |
| contentResult += `${this.Block(block)}\n`; | ||
| try { | ||
| if (index === 0 && Entry.TextCodingUtil.isEventBlock(block)) { | ||
| rootResult = `${this.Block(block)}\n`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if (index === 0 && Entry.TextCodingUtil.isEventBlock(block)) { | ||
| rootResult = `${this.Block(block)}\n`; | ||
| } else { | ||
| contentResult += `${this.Block(block)}\n`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.23.0