-
Notifications
You must be signed in to change notification settings - Fork 496
[4.23.0] 하드웨어 1.9.40 PR #2469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.23.0] 하드웨어 1.9.40 PR #2469
Conversation
- 이벤트블럭 하위에 하드웨어 블록 붙일떄, 최적화 필요
코알라보드(헬로긱스) 추가
RobokitRS 추가 및 기존 하드웨어 수정
비트브릭 블록 오류 수정
|
|
||
| const EVENT_INTERVAL = 150; | ||
|
|
||
| (function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
| (function () { | |
| (function() { |
|
|
||
| const EVENT_INTERVAL = 150; | ||
|
|
||
| (function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected space before function parentheses.
| (function () { | |
| (function() { |
|
|
||
| if (this.version === '2') { | ||
| Entry.addEventListener('run', this.handleBtnEventInterval.bind(this)); | ||
| Entry.addEventListener('beforeStop', () => { clearInterval(this.btnEventIntervalId) }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| if (this.version === '2') { | ||
| Entry.addEventListener('run', this.handleBtnEventInterval.bind(this)); | ||
| Entry.addEventListener('beforeStop', () => { clearInterval(this.btnEventIntervalId) }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Statement inside of curly braces should be on next line.
| Entry.addEventListener('beforeStop', () => { clearInterval(this.btnEventIntervalId) }); | |
| Entry.addEventListener('beforeStop', () => { | |
| clearInterval(this.btnEventIntervalId) }); |
|
|
||
| if (this.version === '2') { | ||
| Entry.addEventListener('run', this.handleBtnEventInterval.bind(this)); | ||
| Entry.addEventListener('beforeStop', () => { clearInterval(this.btnEventIntervalId) }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·clearInterval(this.btnEventIntervalId) with ⏎····················clearInterval(this.btnEventIntervalId);⏎···············
| Entry.addEventListener('beforeStop', () => { clearInterval(this.btnEventIntervalId) }); | |
| Entry.addEventListener('beforeStop', () => { | |
| clearInterval(this.btnEventIntervalId); | |
| }); |
| microbit2lite_get_gesture: | ||
| "When the selected movement is detected, it is judged as 'True'.", | ||
| microbit2lite_get_acc: 'The acceleration value of the selected axis.', | ||
| microbit2lite_btn_event: 'When the selected button is pressed, the connected blocks below will run', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···························
| microbit2lite_btn_event: 'When the selected button is pressed, the connected blocks below will run', | |
| microbit2lite_btn_event: | |
| 'When the selected button is pressed, the connected blocks below will run', |
| } | ||
|
|
||
| getBlocks = function() { | ||
| getBlocks = function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
| getBlocks = function () { | |
| getBlocks = function() { |
| } | ||
|
|
||
| getBlocks = function() { | ||
| getBlocks = function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected space before function parentheses.
| getBlocks = function () { | |
| getBlocks = function() { |
| }, | ||
| ], | ||
| def: { | ||
| type: 'microbit2lite_btn_event' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ,
| type: 'microbit2lite_btn_event' | |
| type: 'microbit2lite_btn_event', |
| func: (sprite, script) => { | ||
| return script.callReturn(); | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected block statement surrounding arrow body; move the returned value immediately after the =>.
| func: (sprite, script) => { | |
| return script.callReturn(); | |
| }, | |
| func: (sprite, script) => script.callReturn(), |
https://oss.navercorp.com/entry/entry2/issues/5966