Skip to content

Conversation

@Tnks2U
Copy link
Collaborator

@Tnks2U Tnks2U commented Mar 21, 2023

@Tnks2U Tnks2U self-assigned this Mar 21, 2023

const EVENT_INTERVAL = 150;

(function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·

Suggested change
(function () {
(function() {


const EVENT_INTERVAL = 150;

(function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Suggested change
(function () {
(function() {


if (this.version === '2') {
Entry.addEventListener('run', this.handleBtnEventInterval.bind(this));
Entry.addEventListener('beforeStop', () => { clearInterval(this.btnEventIntervalId) });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 103. Maximum allowed is 100.


if (this.version === '2') {
Entry.addEventListener('run', this.handleBtnEventInterval.bind(this));
Entry.addEventListener('beforeStop', () => { clearInterval(this.btnEventIntervalId) });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <brace-style> reported by reviewdog 🐶
Statement inside of curly braces should be on next line.

Suggested change
Entry.addEventListener('beforeStop', () => { clearInterval(this.btnEventIntervalId) });
Entry.addEventListener('beforeStop', () => {
clearInterval(this.btnEventIntervalId) });


if (this.version === '2') {
Entry.addEventListener('run', this.handleBtnEventInterval.bind(this));
Entry.addEventListener('beforeStop', () => { clearInterval(this.btnEventIntervalId) });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·clearInterval(this.btnEventIntervalId) with ⏎····················clearInterval(this.btnEventIntervalId);⏎···············

Suggested change
Entry.addEventListener('beforeStop', () => { clearInterval(this.btnEventIntervalId) });
Entry.addEventListener('beforeStop', () => {
clearInterval(this.btnEventIntervalId);
});

microbit2lite_get_gesture:
"When the selected movement is detected, it is judged as 'True'.",
microbit2lite_get_acc: 'The acceleration value of the selected axis.',
microbit2lite_btn_event: 'When the selected button is pressed, the connected blocks below will run',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···························

Suggested change
microbit2lite_btn_event: 'When the selected button is pressed, the connected blocks below will run',
microbit2lite_btn_event:
'When the selected button is pressed, the connected blocks below will run',

}

getBlocks = function() {
getBlocks = function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·

Suggested change
getBlocks = function () {
getBlocks = function() {

}

getBlocks = function() {
getBlocks = function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Suggested change
getBlocks = function () {
getBlocks = function() {

},
],
def: {
type: 'microbit2lite_btn_event'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ,

Suggested change
type: 'microbit2lite_btn_event'
type: 'microbit2lite_btn_event',

Comment on lines +1963 to +1965
func: (sprite, script) => {
return script.callReturn();
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <arrow-body-style> reported by reviewdog 🐶
Unexpected block statement surrounding arrow body; move the returned value immediately after the =>.

Suggested change
func: (sprite, script) => {
return script.callReturn();
},
func: (sprite, script) => script.callReturn(),

@kimorkim kimorkim merged commit dc518b8 into develop Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants