[1.9.42] 버전업 PR #632

Tnks2U · 2023-05-22T09:15:52Z

하드웨어 1.9.42

신규 하드웨어

[네오3D솔루션] 네오캐논 (네오캐논 교구 신규 등록 entryjs#2498, 네오캐논 교구 신규 등록 #631) (샘플미수령)
[AT로봇] 로봇까무 (230512_딜레이시간 변경 entryjs#2499) (샘플없음)
- '동작이 실행중인가?' 블럭의 연결안정성 수정
[누구나] 달고나 제어보드 (달고나 제어보드 디지털, 아날로그 블록 생성 entryjs#2483 ,글자 및 선 구분 수정, 최종 PR entryjs#2500) (샘플있음)

기존 하드웨어

[표쌤코딩] 공유보드 (공유보드 업데이트 2305 entryjs#2496, Develop hw #630) (샘플없음)
- ''터치 %1 센서값'' 블록 제거
- 펌웨어, 썸네일 이미지 업데이트
[네오피아] NEO, 뉴 네오봇, 네오쏘코, 네오씽카 동시 수정([네오피아] 버그 수정 entryjs#2503) (샘플있음)
- 연결 안전성 업데이트
- lcd 블럭의 옵션값이 숫자로 나오던 문제를 이미지이름으로 나오도록 수정
- 블럭 카테고리 구분을 위한 타이틀 추가
- 모터 왼쪽 오른쪽이 뒤바뀌던 버그 수정
- 웹연결에도 동일하게 적용

잘못된 적용삭제

잘못된 파일

하드웨어 이미지 교체/블록 추가

하드웨어 이미지 변경, 블록 추가 및 수정

…to develop-hw

This reverts commit 71a2b1c.

This reverts commit d1ad6b9.

This reverts commit 87f36f7.

This reverts commit 917ffb0.

This reverts commit 6231eee.

This reverts commit f2bd8d2.

This reverts commit d756487.

This reverts commit dab96b2.

Develop hw

네오캐논 교구 신규 등록

Develop hw

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

app/modules/dalgona.js|1051 col 34| Unexpected space before function parentheses.
app/modules/dalgona.js|1058 col 43| Unexpected space before function parentheses.
app/modules/neo_cannon.js|194 col 13| Expected { after 'if' condition.

github-actions · 2023-05-22T09:18:18Z

app/modules/dalgona.js

+
+let sensorIdx = 0;
+
+Module.prototype.init = function (handler, config) {};


⚠️ [eslint] <space-before-function-paren> _{reported by reviewdog 🐶}
Unexpected space before function parentheses.

Suggested change

Module.prototype.init = function (handler, config) {};

Module.prototype.init = function(handler, config) {};

github-actions · 2023-05-22T09:18:18Z

app/modules/dalgona.js

+
+Module.prototype.init = function (handler, config) {};
+
+Module.prototype.setSerialPort = function (sp) {


⚠️ [eslint] <space-before-function-paren> _{reported by reviewdog 🐶}
Unexpected space before function parentheses.

Suggested change

Module.prototype.setSerialPort = function (sp) {

Module.prototype.setSerialPort = function(sp) {

github-actions · 2023-05-22T09:18:18Z

app/modules/dalgona.js

+    this.sp = sp;
+};
+
+Module.prototype.requestInitialData = function () {


⚠️ [eslint] <space-before-function-paren> _{reported by reviewdog 🐶}
Unexpected space before function parentheses.

Suggested change

Module.prototype.requestInitialData = function () {

Module.prototype.requestInitialData = function() {

github-actions · 2023-05-22T09:18:18Z

app/modules/dalgona.js

+    //return this.makeSensorReadBuffer(this.sensorTypes.ANALOG, 0);
+};
+
+Module.prototype.checkInitialData = function (data, config) {


⚠️ [eslint] <space-before-function-paren> _{reported by reviewdog 🐶}
Unexpected space before function parentheses.

Suggested change

Module.prototype.checkInitialData = function (data, config) {

Module.prototype.checkInitialData = function(data, config) {

github-actions · 2023-05-22T09:18:18Z

app/modules/dalgona.js

+    // return isValidData;
+};
+
+Module.prototype.afterConnect = function (that, cb) {


⚠️ [eslint] <space-before-function-paren> _{reported by reviewdog 🐶}
Unexpected space before function parentheses.

Suggested change

Module.prototype.afterConnect = function (that, cb) {

Module.prototype.afterConnect = function(that, cb) {

github-actions · 2023-05-22T09:18:22Z

app/modules/dalgona.js

+            if ($.isPlainObject(data)) {
+                textLen = ('' + data.text).length;
+                // console.log(textLen);
+                text = Buffer.from('' + data.text, 'ascii');


⚠️ [eslint] <prefer-template> _{reported by reviewdog 🐶}
Unexpected string concatenation.

Suggested change

text = Buffer.from('' + data.text, 'ascii');

text = Buffer.from(`${ data.text}`, 'ascii');

github-actions · 2023-05-22T09:18:22Z

app/modules/dalgona.js

+        case this.sensorTypes.MP3PLAY2: {
+            const tx = new Buffer(2);
+            const num = new Buffer(2);
+            const time_value = new Buffer(2);


⚠️ [eslint] <camelcase> _{reported by reviewdog 🐶}
Identifier 'time_value' is not in camel case.

github-actions · 2023-05-22T09:18:22Z

app/modules/dalgona.js

+
+            buffer = new Buffer([255, 85, 10, sensorIdx, this.actionTypes.SET, device, port]);
+
+            buffer = Buffer.concat([buffer, tx, num, time_value, dummy]);


⚠️ [eslint] <camelcase> _{reported by reviewdog 🐶}
Identifier 'time_value' is not in camel case.

github-actions · 2023-05-22T09:18:22Z

app/modules/dalgona.js

+    return buffer;
+};
+
+Module.prototype.getDataByBuffer = function (buffer) {


⚠️ [eslint] <space-before-function-paren> _{reported by reviewdog 🐶}
Unexpected space before function parentheses.

Suggested change

Module.prototype.getDataByBuffer = function (buffer) {

Module.prototype.getDataByBuffer = function(buffer) {

github-actions · 2023-05-22T09:18:23Z

app/modules/dalgona.js

+    return datas;
+};
+
+Module.prototype.disconnect = function (connect) {


⚠️ [eslint] <space-before-function-paren> _{reported by reviewdog 🐶}
Unexpected space before function parentheses.

Suggested change

Module.prototype.disconnect = function (connect) {

Module.prototype.disconnect = function(connect) {

dalgona-edu and others added 30 commits April 6, 2023 17:21

아두이노 5개 기본 블럭 동작 확인

350026b

url 링크 수정

bc21437

디지털 핀 콘솔 출력

777a287

디지털, 아날로그 출력 로그

734d50d

환경 전체 업로드

dab96b2

이미지 변경

d756487

ID값 적용

f2bd8d2

보드 명칭 변경

6231eee

라이브러리 동작 확인

917ffb0

Delete eduino.js

87f36f7

잘못된 적용삭제

Delete package-lock.json

d1ad6b9

잘못된 파일

Delete yarn.lock

71a2b1c

잘못된 파일

표쌤코딩 하드웨어 기능 수정

23df16a

하드웨어 이미지 교체/블록 추가

표쌤코딩 하드웨어 기능 수정

1268813

하드웨어 이미지 교체/블록 추가

Upload NeoCannon & TODO: id값 수정

1f6f0a5

공유보드 업데이트_2305

ad5c3d2

하드웨어 이미지 변경, 블록 추가 및 수정

Merge branch 'develop-hw' of https://github.com/pyocoding/entry-hw in…

4aae1c3

…to develop-hw

ID값 부여

2974c86

ESLint 규칙 맞춤

72aae0b

Revert "Delete yarn.lock"

1fe4b5f

This reverts commit 71a2b1c.

Revert "Delete package-lock.json"

291b154

This reverts commit d1ad6b9.

Revert "Delete eduino.js"

0db0095

This reverts commit 87f36f7.

Revert "라이브러리 동작 확인"

caff259

This reverts commit 917ffb0.

Revert "보드 명칭 변경"

ad898f1

This reverts commit 6231eee.

Revert "ID값 적용"

0ef685b

This reverts commit f2bd8d2.

Revert "이미지 변경"

bed5adb

This reverts commit d756487.

Revert "환경 전체 업로드"

9f2d100

This reverts commit dab96b2.

하드웨어 전체 업데이트

8624c1b

엔트리 등록 전 블럭 이상 테스트

edbb8f4

Merge pull request #627 from dalgona-edu/develop-hw

ad828c2

Develop hw

Tnks2U and others added 3 commits May 22, 2023 15:31

Merge pull request #631 from Neo3ds/develop-hw

b36087e

네오캐논 교구 신규 등록

Merge pull request #630 from pyocoding/develop-hw

8cd966a

Develop hw

chore: 1.9.42 버전업

7330dd2

Tnks2U requested review from kimorkim, lizwan and prisml May 22, 2023 09:15

Tnks2U merged commit ed9097e into master May 22, 2023

github-actions bot reviewed May 22, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[1.9.42] 버전업 PR #632

[1.9.42] 버전업 PR #632

Uh oh!

Tnks2U commented May 22, 2023

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot May 22, 2023

Uh oh!

github-actions bot May 22, 2023

Uh oh!

github-actions bot May 22, 2023

Uh oh!

github-actions bot May 22, 2023

Uh oh!

github-actions bot May 22, 2023

Uh oh!

github-actions bot May 22, 2023

Uh oh!

github-actions bot May 22, 2023

Uh oh!

github-actions bot May 22, 2023

Uh oh!

github-actions bot May 22, 2023

Uh oh!

github-actions bot May 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants


		let sensorIdx = 0;

		Module.prototype.init = function (handler, config) {};

	Module.prototype.init = function (handler, config) {};
	Module.prototype.init = function(handler, config) {};


		Module.prototype.init = function (handler, config) {};

		Module.prototype.setSerialPort = function (sp) {

	Module.prototype.requestInitialData = function () {
	Module.prototype.requestInitialData = function() {

	Module.prototype.checkInitialData = function (data, config) {
	Module.prototype.checkInitialData = function(data, config) {

	Module.prototype.afterConnect = function (that, cb) {
	Module.prototype.afterConnect = function(that, cb) {

	text = Buffer.from('' + data.text, 'ascii');
	text = Buffer.from(`${ data.text}`, 'ascii');


		buffer = new Buffer([255, 85, 10, sensorIdx, this.actionTypes.SET, device, port]);

		buffer = Buffer.concat([buffer, tx, num, time_value, dummy]);

	Module.prototype.getDataByBuffer = function (buffer) {
	Module.prototype.getDataByBuffer = function(buffer) {

	Module.prototype.disconnect = function (connect) {
	Module.prototype.disconnect = function(connect) {

[1.9.42] 버전업 PR #632

[1.9.42] 버전업 PR #632

Uh oh!

Conversation

Tnks2U commented May 22, 2023

하드웨어 1.9.42

신규 하드웨어

기존 하드웨어

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 22, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 22, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 22, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 22, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 22, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 22, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 22, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 22, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 22, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 22, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants