Skip to content

Commit ae1488c

Browse files
author
Jonah Williams
authored
[Impeller] skip selectable text goldens for instability. (#143627)
Similar to other issues, appears that text goldens are really unstable with Impeller. Part of flutter/flutter#143616
1 parent 789acb3 commit ae1488c

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

packages/flutter/test/widgets/selectable_text_test.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import 'package:flutter/rendering.dart';
1919
import 'package:flutter/services.dart';
2020
import 'package:flutter_test/flutter_test.dart';
2121

22+
import '../impeller_test_helpers.dart';
2223
import '../widgets/clipboard_utils.dart';
2324
import '../widgets/editable_text_utils.dart' show textOffsetToPosition;
2425
import '../widgets/semantics_tester.dart';
@@ -5370,7 +5371,7 @@ void main() {
53705371
find.byType(MaterialApp),
53715372
matchesGoldenFile('selectable_text_golden.TextSelectionStyle.1.png'),
53725373
);
5373-
});
5374+
}, skip: impellerEnabled); // https://github.com/flutter/flutter/issues/143616
53745375

53755376
testWidgets('text selection style 2', (WidgetTester tester) async {
53765377
await tester.pumpWidget(
@@ -5422,7 +5423,7 @@ void main() {
54225423
find.byType(MaterialApp),
54235424
matchesGoldenFile('selectable_text_golden.TextSelectionStyle.2.png'),
54245425
);
5425-
});
5426+
}, skip: impellerEnabled); // https://github.com/flutter/flutter/issues/143616
54265427

54275428
testWidgets('keeps alive when has focus', (WidgetTester tester) async {
54285429
await tester.pumpWidget(

0 commit comments

Comments
 (0)