Skip to content

Commit ac8deab

Browse files
Flip stable web testing to canvaskit
1 parent 971eac0 commit ac8deab

File tree

2 files changed

+1
-62
lines changed

2 files changed

+1
-62
lines changed

script/tool/lib/src/drive_examples_command.dart

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -130,11 +130,7 @@ class DriveExamplesCommand extends PackageLoopingCommand {
130130
'--browser-name=chrome',
131131
if (useWasm)
132132
'--wasm'
133-
// TODO(dit): Clean this up, https://github.com/flutter/flutter/issues/151869
134-
else if (platform.environment['CHANNEL']?.toLowerCase() == 'master')
135-
'--web-renderer=canvaskit'
136-
else
137-
'--web-renderer=html',
133+
'--web-renderer=canvaskit'
138134
if (platform.environment.containsKey('CHROME_EXECUTABLE'))
139135
'--chrome-binary=${platform.environment['CHROME_EXECUTABLE']}',
140136
],

script/tool/test/drive_examples_command_test.dart

Lines changed: 0 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,6 @@ void main() {
3838
runner = CommandRunner<void>(
3939
'drive_examples_command', 'Test for drive_example_command');
4040
runner.addCommand(command);
41-
42-
// TODO(dit): Clean this up, https://github.com/flutter/flutter/issues/151869
43-
mockPlatform.environment['CHANNEL'] = 'master';
4441
});
4542

4643
void setMockFlutterDevicesOutput({
@@ -760,60 +757,6 @@ void main() {
760757
]));
761758
});
762759

763-
// TODO(dit): Clean this up, https://github.com/flutter/flutter/issues/151869
764-
test('drives a web plugin (html renderer in stable)', () async {
765-
// Override the platform to simulate CHANNEL: stable
766-
mockPlatform.environment['CHANNEL'] = 'stable';
767-
768-
final RepositoryPackage plugin = createFakePlugin(
769-
'plugin',
770-
packagesDir,
771-
extraFiles: <String>[
772-
'example/integration_test/plugin_test.dart',
773-
'example/test_driver/integration_test.dart',
774-
'example/web/index.html',
775-
],
776-
platformSupport: <String, PlatformDetails>{
777-
platformWeb: const PlatformDetails(PlatformSupport.inline),
778-
},
779-
);
780-
781-
final Directory pluginExampleDirectory = getExampleDir(plugin);
782-
783-
final List<String> output = await runCapturingPrint(runner, <String>[
784-
'drive-examples',
785-
'--web',
786-
]);
787-
788-
expect(
789-
output,
790-
containsAllInOrder(<Matcher>[
791-
contains('Running for plugin'),
792-
contains('No issues found!'),
793-
]),
794-
);
795-
796-
expect(
797-
processRunner.recordedCalls,
798-
orderedEquals(<ProcessCall>[
799-
ProcessCall(
800-
getFlutterCommand(mockPlatform),
801-
const <String>[
802-
'drive',
803-
'-d',
804-
'web-server',
805-
'--web-port=7357',
806-
'--browser-name=chrome',
807-
'--web-renderer=html',
808-
'--driver',
809-
'test_driver/integration_test.dart',
810-
'--target',
811-
'integration_test/plugin_test.dart',
812-
],
813-
pluginExampleDirectory.path),
814-
]));
815-
});
816-
817760
test('runs chromedriver when requested', () async {
818761
final RepositoryPackage plugin = createFakePlugin(
819762
'plugin',

0 commit comments

Comments
 (0)