[tool] Add command aliases (flutter#4207)

Adds aliases for all commands that put the verb first, since currently they are inconsistent which can make it hard to remember (in particular, I often write `check-foo` instead of `foo-check` when running locally, and it fails).

Also does the long-overdue renaming of `test` to `dart-test`, since we now have `native-test`, `custom-test`, etc. `test` continues to work as an alias for individual muscle memory.

Author: stuartmorgan-g

.ci/scripts/dart_unit_tests_win32.sh

@@ -4,6 +4,6 @@
 # found in the LICENSE file.
 set -e
 
-dart ./script/tool/bin/flutter_plugin_tools.dart test \
+dart ./script/tool/bin/flutter_plugin_tools.dart dart-test \
   --exclude=script/configs/windows_unit_tests_exceptions.yaml \
   --packages-for-branch --log-timing

.cirrus.yml

@@ -231,13 +231,13 @@ task:
           CHANNEL: "master"
           CHANNEL: "stable"
       unit_test_script:
-        - ./script/tool_runner.sh test --exclude=script/configs/dart_unit_tests_exceptions.yaml
+        - ./script/tool_runner.sh dart-test --exclude=script/configs/dart_unit_tests_exceptions.yaml
       pathified_unit_test_script:
         # Run tests with path-based dependencies to ensure that publishing
         # the changes won't break tests of other packages in the repository
         # that depend on it.
         - ./script/tool_runner.sh make-deps-path-based --target-dependencies-with-non-breaking-updates
-        - $PLUGIN_TOOL_COMMAND test --run-on-dirty-packages --exclude=script/configs/dart_unit_tests_exceptions.yaml
+        - $PLUGIN_TOOL_COMMAND dart-test --run-on-dirty-packages --exclude=script/configs/dart_unit_tests_exceptions.yaml
     - name: linux-custom_package_tests
       env:
         PATH: $PATH:/usr/local/bin

script/tool/lib/src/custom_test_command.dart

@@ -28,6 +28,9 @@ class CustomTestCommand extends PackageLoopingCommand {
   @override
   final String name = 'custom-test';
 
+  @override
+  List<String> get aliases => <String>['test-custom'];
+
   @override
   final String description = 'Runs package-specific custom tests defined in '
       "a package's tool/$_scriptName file.\n\n"

script/tool/lib/src/test_command.dart renamed to script/tool/lib/src/dart_test_command.dart

@@ -12,9 +12,9 @@ import 'common/process_runner.dart';
 import 'common/repository_package.dart';
 
 /// A command to run Dart unit tests for packages.
-class TestCommand extends PackageLoopingCommand {
+class DartTestCommand extends PackageLoopingCommand {
   /// Creates an instance of the test command.
-  TestCommand(
+  DartTestCommand(
     Directory packagesDir, {
     ProcessRunner processRunner = const ProcessRunner(),
     Platform platform = const LocalPlatform(),
@@ -30,7 +30,13 @@ class TestCommand extends PackageLoopingCommand {
   }
 
   @override
-  final String name = 'test';
+  final String name = 'dart-test';
+
+  // TODO(stuartmorgan): Eventually remove 'test', which is a legacy name from
+  // before there were other test commands that made it ambiguous. For now it's
+  // an alias to avoid breaking people's workflows.
+  @override
+  List<String> get aliases => <String>['test', 'test-dart'];
 
   @override
   final String description = 'Runs the Dart tests for all packages.\n\n'

script/tool/lib/src/dependabot_check_command.dart

@@ -32,6 +32,9 @@ class DependabotCheckCommand extends PackageLoopingCommand {
   @override
   final String name = 'dependabot-check';
 
+  @override
+  List<String> get aliases => <String>['check-dependabot'];
+
   @override
   final String description =
       'Checks that all packages have Dependabot coverage.';

script/tool/lib/src/federation_safety_check_command.dart

@@ -52,6 +52,9 @@ class FederationSafetyCheckCommand extends PackageLoopingCommand {
   @override
   final String name = 'federation-safety-check';
 
+  @override
+  List<String> get aliases => <String>['check-federation-safety'];
+
   @override
   final String description =
       'Checks that the change does not violate repository rules around changes '

script/tool/lib/src/gradle_check_command.dart

@@ -23,6 +23,9 @@ class GradleCheckCommand extends PackageLoopingCommand {
   @override
   final String name = 'gradle-check';
 
+  @override
+  List<String> get aliases => <String>['check-gradle'];
+
   @override
   final String description =
       'Checks that gradle files follow repository conventions.';

script/tool/lib/src/license_check_command.dart

@@ -114,6 +114,9 @@ class LicenseCheckCommand extends PackageCommand {
   @override
   final String name = 'license-check';
 
+  @override
+  List<String> get aliases => <String>['check-license'];
+
   @override
   final String description =
       'Ensures that all code files have copyright/license blocks.';

script/tool/lib/src/main.dart

@@ -13,6 +13,7 @@ import 'build_examples_command.dart';
 import 'common/core.dart';
 import 'create_all_packages_app_command.dart';
 import 'custom_test_command.dart';
+import 'dart_test_command.dart';
 import 'dependabot_check_command.dart';
 import 'drive_examples_command.dart';
 import 'federation_safety_check_command.dart';
@@ -31,7 +32,6 @@ import 'publish_command.dart';
 import 'pubspec_check_command.dart';
 import 'readme_check_command.dart';
 import 'remove_dev_dependencies_command.dart';
-import 'test_command.dart';
 import 'update_dependency_command.dart';
 import 'update_excerpts_command.dart';
 import 'update_min_sdk_command.dart';
@@ -80,7 +80,7 @@ void main(List<String> args) {
     ..addCommand(PubspecCheckCommand(packagesDir))
     ..addCommand(ReadmeCheckCommand(packagesDir))
     ..addCommand(RemoveDevDependenciesCommand(packagesDir))
-    ..addCommand(TestCommand(packagesDir))
+    ..addCommand(DartTestCommand(packagesDir))
     ..addCommand(UpdateDependencyCommand(packagesDir))
     ..addCommand(UpdateExcerptsCommand(packagesDir))
     ..addCommand(UpdateMinSdkCommand(packagesDir))

script/tool/lib/src/native_test_command.dart

@@ -73,6 +73,9 @@ class NativeTestCommand extends PackageLoopingCommand {
   @override
   final String name = 'native-test';
 
+  @override
+  List<String> get aliases => <String>['test-native'];
+
   @override
   final String description = '''
 Runs native unit tests and native integration tests.