Skip to content

Commit 4056639

Browse files
authored
Change flag internalAddSemanticForOnTap default value to true (#153193)
This is a follow up on flutter/flutter#152526 1. Make changes with an additional parameter ( bool internalAddSemanticForOnTap = false) (flutter/flutter#152526 ) 2. Send regular CLs in google3 to pass internalAddSemanticForOnTap: true, and update the tests / text goldens 3. accordingly. g3 fix sent: cl/661353802 3. Send a PR to flip the default value to true. (This PR) 4. Send CLs internally to remove internalAddSemanticForOnTap: true. 5. Send another PR to remove the now-redundant internalAddSemanticForOnTap flag. (<----This PR is step 3)
1 parent fd26daa commit 4056639

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

packages/flutter/lib/src/material/list_tile.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ class ListTile extends StatelessWidget {
410410
this.minLeadingWidth,
411411
this.minTileHeight,
412412
this.titleAlignment,
413-
this.internalAddSemanticForOnTap = false,
413+
this.internalAddSemanticForOnTap = true,
414414
}) : assert(!isThreeLine || subtitle != null);
415415

416416
/// A widget to display before the title.

packages/flutter/test/material/list_tile_test.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -270,22 +270,18 @@ void main() {
270270
children: <Widget>[
271271
const ListTile(
272272
title: Text('one'),
273-
internalAddSemanticForOnTap: true,
274273
),
275274
ListTile(
276275
title: const Text('two'),
277276
onTap: () {},
278-
internalAddSemanticForOnTap: true,
279277
),
280278
const ListTile(
281279
title: Text('three'),
282280
selected: true,
283-
internalAddSemanticForOnTap: true,
284281
),
285282
const ListTile(
286283
title: Text('four'),
287284
enabled: false,
288-
internalAddSemanticForOnTap: true,
289285
),
290286
],
291287
),

0 commit comments

Comments
 (0)