Skip to content

Commit 095f46c

Browse files
author
Jonah Williams
authored
[Impeller] remove Adreno denylist entries. (#161740)
Fixes flutter/flutter#161209 testing on a 540 and everything seems to work now that we have the Adreno specific workarounds added to the renderer. Its possible there are some bugs that only exist on the early 600s but I guess we'll find out.
1 parent f2ce662 commit 095f46c

File tree

2 files changed

+9
-19
lines changed

2 files changed

+9
-19
lines changed

engine/src/flutter/impeller/renderer/backend/vulkan/driver_info_vk.cc

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -329,15 +329,6 @@ bool DriverInfoVK::IsEmulator() const {
329329
}
330330

331331
bool DriverInfoVK::IsKnownBadDriver() const {
332-
if (adreno_gpu_.has_value()) {
333-
AdrenoGPU adreno = adreno_gpu_.value();
334-
// 630 is the lowest version I've tested on the still works.
335-
// I suspect earlier 600s should work but this is waiting on
336-
// more devices for testing.
337-
if (adreno < AdrenoGPU::kAdreno630) {
338-
return true;
339-
}
340-
}
341332
// Disable Maleoon series GPUs, see:
342333
// https://github.com/flutter/flutter/issues/156623
343334
if (vendor_ == VendorVK::kHuawei) {

engine/src/flutter/impeller/renderer/backend/vulkan/driver_info_vk_unittests.cc

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -163,16 +163,15 @@ TEST(DriverInfoVKTest, DriverParsingAdreno) {
163163
}
164164

165165
TEST(DriverInfoVKTest, DisabledDevices) {
166-
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 620"));
167-
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 610"));
168-
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 530"));
169-
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 512"));
170-
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 509"));
171-
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 508"));
172-
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 506"));
173-
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 505"));
174-
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 504"));
175-
166+
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 620"));
167+
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 610"));
168+
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 530"));
169+
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 512"));
170+
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 509"));
171+
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 508"));
172+
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 506"));
173+
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 505"));
174+
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 504"));
176175
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 630"));
177176
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 640"));
178177
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 650"));

0 commit comments

Comments
 (0)