Set caches directory on Fuchsia (flutter#18321)

George Wright · web-flow · commit cdc5ed3ad95a · 2020-05-20T11:05:55.000-07:00
diff --git a/fml/platform/fuchsia/paths_fuchsia.cc b/fml/platform/fuchsia/paths_fuchsia.cc
@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "flutter/fml/file.h"
 #include "flutter/fml/paths.h"
 
 namespace fml {
@@ -12,8 +13,7 @@ std::pair<bool, std::string> GetExecutableDirectoryPath() {
 }
 
 fml::UniqueFD GetCachesDirectory() {
-  // Unsupported on this platform.
-  return {};
+  return OpenDirectory("/cache", false, fml::FilePermission::kRead);
 }
 
 }  // namespace paths
diff --git a/shell/platform/fuchsia/flutter/meta/flutter_aot_product_runner.cmx b/shell/platform/fuchsia/flutter/meta/flutter_aot_product_runner.cmx
@@ -6,7 +6,8 @@
     "features": [
       "config-data",
       "root-ssl-certificates",
-      "vulkan"
+      "vulkan",
+      "isolated-cache-storage"
     ],
     "services": [
       "fuchsia.accessibility.SettingsManager",
diff --git a/shell/platform/fuchsia/flutter/meta/flutter_aot_runner.cmx b/shell/platform/fuchsia/flutter/meta/flutter_aot_runner.cmx
@@ -6,7 +6,8 @@
     "features": [
       "config-data",
       "root-ssl-certificates",
-      "vulkan"
+      "vulkan",
+      "isolated-cache-storage"
     ],
     "services": [
       "fuchsia.accessibility.SettingsManager",
diff --git a/shell/platform/fuchsia/flutter/meta/flutter_jit_product_runner.cmx b/shell/platform/fuchsia/flutter/meta/flutter_jit_product_runner.cmx
@@ -7,7 +7,8 @@
       "config-data",
       "deprecated-ambient-replace-as-executable",
       "root-ssl-certificates",
-      "vulkan"
+      "vulkan",
+      "isolated-cache-storage"
     ],
     "services": [
       "fuchsia.accessibility.SettingsManager",
diff --git a/shell/platform/fuchsia/flutter/meta/flutter_jit_runner.cmx b/shell/platform/fuchsia/flutter/meta/flutter_jit_runner.cmx
@@ -7,7 +7,8 @@
       "config-data",
       "deprecated-ambient-replace-as-executable",
       "root-ssl-certificates",
-      "vulkan"
+      "vulkan",
+      "isolated-cache-storage"
     ],
     "services": [
       "fuchsia.accessibility.SettingsManager",
diff --git a/testing/fuchsia/meta/fuchsia_test.cmx b/testing/fuchsia/meta/fuchsia_test.cmx
@@ -5,7 +5,8 @@
   "sandbox": {
     "features": [
       "vulkan",
-      "deprecated-ambient-replace-as-executable"
+      "deprecated-ambient-replace-as-executable",
+      "isolated-cache-storage"
     ],
     "services": [
       "fuchsia.accessibility.semantics.SemanticsManager",

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`	`// Use of this source code is governed by a BSD-style license that can be`
`3`	`3`	`// found in the LICENSE file.`
`4`	`4`
	`5`	`+#include "flutter/fml/file.h"`
`5`	`6`	`#include "flutter/fml/paths.h"`
`6`	`7`
`7`	`8`	`namespace fml {`
`@@ -12,8 +13,7 @@ std::pair<bool, std::string> GetExecutableDirectoryPath() {`
`12`	`13`	`}`
`13`	`14`
`14`	`15`	`fml::UniqueFD GetCachesDirectory() {`
`15`		`- // Unsupported on this platform.`
`16`		`- return {};`
	`16`	`+ return OpenDirectory("/cache", false, fml::FilePermission::kRead);`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`} // namespace paths`